From d27ab42ce6cd0a32a9a3cfb2636bbf75ace990fb Mon Sep 17 00:00:00 2001 From: MarcoGorelli <33491632+MarcoGorelli@users.noreply.github.com> Date: Tue, 20 Jun 2023 17:05:25 +0100 Subject: [PATCH 1/5] note pow return type --- spec/API_specification/dataframe_api/column_object.py | 3 +++ spec/API_specification/dataframe_api/dataframe_object.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/spec/API_specification/dataframe_api/column_object.py b/spec/API_specification/dataframe_api/column_object.py index 17722f5f..13d6fce9 100644 --- a/spec/API_specification/dataframe_api/column_object.py +++ b/spec/API_specification/dataframe_api/column_object.py @@ -295,6 +295,9 @@ def __pow__(self, other: Column | Scalar) -> Column: """ Raise this column to the power of `other`. + Integer to the power of non-negative integer is integer. + Float to the power of integer or float is float. + Parameters ---------- other : Column or Scalar diff --git a/spec/API_specification/dataframe_api/dataframe_object.py b/spec/API_specification/dataframe_api/dataframe_object.py index 46773428..ef85352b 100644 --- a/spec/API_specification/dataframe_api/dataframe_object.py +++ b/spec/API_specification/dataframe_api/dataframe_object.py @@ -528,6 +528,9 @@ def __pow__(self, other: DataFrame | Scalar) -> DataFrame: """ Raise this dataframe to the power of `other`. + Integer to the power of non-negative integer is integer. + Float to the power of integer or float is float. + Parameters ---------- other : DataFrame or Scalar From 350b4a1c21eb67b8c837ef7772dad017df69f821 Mon Sep 17 00:00:00 2001 From: MarcoGorelli <33491632+MarcoGorelli@users.noreply.github.com> Date: Wed, 21 Jun 2023 12:09:11 +0100 Subject: [PATCH 2/5] use dtype --- spec/API_specification/dataframe_api/column_object.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/API_specification/dataframe_api/column_object.py b/spec/API_specification/dataframe_api/column_object.py index 13d6fce9..cfcd9663 100644 --- a/spec/API_specification/dataframe_api/column_object.py +++ b/spec/API_specification/dataframe_api/column_object.py @@ -295,8 +295,8 @@ def __pow__(self, other: Column | Scalar) -> Column: """ Raise this column to the power of `other`. - Integer to the power of non-negative integer is integer. - Float to the power of integer or float is float. + Integer dtype to the power of non-negative integer dtype is integer dtype. + Float dtype to the power of integer dtype or float dtype is float dtype. Parameters ---------- From 251d2c3e1d4a2112c2beacd40f5bcbe43a3669df Mon Sep 17 00:00:00 2001 From: MarcoGorelli <33491632+MarcoGorelli@users.noreply.github.com> Date: Mon, 26 Jun 2023 12:01:02 +0100 Subject: [PATCH 3/5] note int to float return type --- spec/API_specification/dataframe_api/dataframe_object.py | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/API_specification/dataframe_api/dataframe_object.py b/spec/API_specification/dataframe_api/dataframe_object.py index ef85352b..04fd65b6 100644 --- a/spec/API_specification/dataframe_api/dataframe_object.py +++ b/spec/API_specification/dataframe_api/dataframe_object.py @@ -529,6 +529,7 @@ def __pow__(self, other: DataFrame | Scalar) -> DataFrame: Raise this dataframe to the power of `other`. Integer to the power of non-negative integer is integer. + Integer to the power of float is float. Float to the power of integer or float is float. Parameters From 61e05a4f4748b92f0b5b1046470e2c32cad364d4 Mon Sep 17 00:00:00 2001 From: Marco Edward Gorelli Date: Thu, 29 Jun 2023 08:28:22 +0100 Subject: [PATCH 4/5] Update spec/API_specification/dataframe_api/dataframe_object.py Co-authored-by: Keith Kraus --- spec/API_specification/dataframe_api/dataframe_object.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/API_specification/dataframe_api/dataframe_object.py b/spec/API_specification/dataframe_api/dataframe_object.py index 04fd65b6..7a283cc9 100644 --- a/spec/API_specification/dataframe_api/dataframe_object.py +++ b/spec/API_specification/dataframe_api/dataframe_object.py @@ -528,9 +528,9 @@ def __pow__(self, other: DataFrame | Scalar) -> DataFrame: """ Raise this dataframe to the power of `other`. - Integer to the power of non-negative integer is integer. - Integer to the power of float is float. - Float to the power of integer or float is float. + Integer dtype to the power of non-negative integer dtype is integer dtype. + Integer dtype to the power of float dtype is float dtype. + Float dtype to the power of integer dtype or float dtype is float dtype. Parameters ---------- From 1101a1a2f940ade5c18b1c6430cbb75a520c4dbb Mon Sep 17 00:00:00 2001 From: Marco Edward Gorelli Date: Thu, 29 Jun 2023 09:30:35 +0100 Subject: [PATCH 5/5] Update spec/API_specification/dataframe_api/column_object.py Co-authored-by: Keith Kraus --- spec/API_specification/dataframe_api/column_object.py | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/API_specification/dataframe_api/column_object.py b/spec/API_specification/dataframe_api/column_object.py index cfcd9663..eef2bed5 100644 --- a/spec/API_specification/dataframe_api/column_object.py +++ b/spec/API_specification/dataframe_api/column_object.py @@ -296,6 +296,7 @@ def __pow__(self, other: Column | Scalar) -> Column: Raise this column to the power of `other`. Integer dtype to the power of non-negative integer dtype is integer dtype. + Integer dtype to the power of float dtype is float dtype. Float dtype to the power of integer dtype or float dtype is float dtype. Parameters