Skip to content

Commit ee1fe4c

Browse files
authored
rename get_rows_by_mask to filter (#246)
1 parent bf214e2 commit ee1fe4c

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

spec/API_specification/dataframe_api/column_object.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def slice_rows(
104104
...
105105

106106

107-
def get_rows_by_mask(self: Column[DType], mask: Column[Bool]) -> Column[DType]:
107+
def filter(self: Column[DType], mask: Column[Bool]) -> Column[DType]:
108108
"""
109109
Select a subset of rows corresponding to a mask.
110110

spec/API_specification/dataframe_api/dataframe_object.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def slice_rows(
161161
"""
162162
...
163163

164-
def get_rows_by_mask(self, mask: Column[Bool]) -> DataFrame:
164+
def filter(self, mask: Column[Bool]) -> DataFrame:
165165
"""
166166
Select a subset of rows corresponding to a mask.
167167

spec/purpose_and_scope.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ def my_dataframe_agnostic_function(df):
287287
df = df.__dataframe_consortium_standard__(api_version='2023.08-beta')
288288

289289
mask = df.get_column_by_name('species') != 'setosa'
290-
df = df.get_rows_by_mask(mask)
290+
df = df.filter(mask)
291291

292292
for column_name in df.get_column_names():
293293
if column_name == 'species':

0 commit comments

Comments
 (0)