Skip to content

Commit 6585fd7

Browse files
authored
DataFrame.get_rows should take Column, not Sequence (#147)
1 parent ef99169 commit 6585fd7

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

spec/API_specification/dataframe_api/dataframe_object.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,24 +88,18 @@ def get_columns_by_name(self, names: Sequence[str], /) -> DataFrame:
8888
"""
8989
...
9090

91-
def get_rows(self, indices: Sequence[int]) -> DataFrame:
91+
def get_rows(self, indices: "Column[int]") -> DataFrame:
9292
"""
9393
Select a subset of rows, similar to `ndarray.take`.
9494
9595
Parameters
9696
----------
97-
indices : Sequence[int]
97+
indices : Column[int]
9898
Positions of rows to select.
9999
100100
Returns
101101
-------
102102
DataFrame
103-
104-
Notes
105-
-----
106-
Some discussion participants prefer a stricter type Column[int] for
107-
indices in order to make it easier to implement in a performant manner
108-
on GPUs.
109103
"""
110104
...
111105

0 commit comments

Comments
 (0)