Skip to content

Add note concerning float sort order #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Add note concerning float sort order #316

merged 1 commit into from
Nov 6, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 5, 2021

This PR

  • resolves Clarify floating-point sort order for ascending and descending sort #288 by adding a note concerning the sort order IEEE 754 floating-point values (NaN, +0, and -0). Currently, array libraries are not consistent in how they sort these values. Accordingly, this PR simply adds a note indicating that the sort order of these values is left unspecified and is thus implementation-dependent.

@kgryte kgryte added the Maintenance Bug fix, typo fix, or general maintenance. label Nov 5, 2021
@kgryte kgryte added this to the v2021 milestone Nov 5, 2021
@kgryte
Copy link
Contributor Author

kgryte commented Nov 6, 2021

Thanks @leofang!

@kgryte kgryte merged commit 568f81f into main Nov 6, 2021
@kgryte kgryte deleted the float-sort-order branch November 6, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify floating-point sort order for ascending and descending sort
2 participants