Skip to content

Incorrect formula in description of linalg.cholesky #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucascolley opened this issue Aug 18, 2023 · 2 comments · Fixed by #677
Closed

Incorrect formula in description of linalg.cholesky #676

lucascolley opened this issue Aug 18, 2023 · 2 comments · Fixed by #677
Labels
bug Something isn't working. Narrative Content Narrative documentation content.
Milestone

Comments

@lucascolley
Copy link
Member

Noted by @izaid here: numpy/numpy#24451 (comment)

U^H should come before U.

Example of discrepancy with the SciPy docs: https://docs.scipy.org/doc/scipy/reference/generated/scipy.linalg.cholesky.html. The SciPy version is consistent with other material I have found online.

image

@kgryte
Copy link
Contributor

kgryte commented Aug 18, 2023

Thanks for identifying. The description for the upper Cholesky decomposition is incorrect. Feel free to submit a PR fixing this typo. The change should be backported to prior revisions of the standard.

@kgryte kgryte added bug Something isn't working. Narrative Content Narrative documentation content. labels Aug 18, 2023
@kgryte kgryte added this to the v2023 milestone Aug 18, 2023
@lucascolley
Copy link
Member Author

lucascolley commented Aug 18, 2023

Sure, I'm happy to submit a PR.

Are those changes to be made in draft and _2022_12 in array_api_stubs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Narrative Content Narrative documentation content.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants