Skip to content

Should finfo have smallest normal/subnormal attributes? #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rgommers opened this issue Feb 21, 2021 · 3 comments
Closed

Should finfo have smallest normal/subnormal attributes? #131

rgommers opened this issue Feb 21, 2021 · 3 comments
Assignees

Comments

@rgommers
Copy link
Member

Following up on gh-129: we removed the tiny attribute from finfo because it's badly named. In the discussion @kgryte explained its purpose and proposed instead to add two new attributes: smallest_normal and smallest_subnormal. That does sound like a good idea, however it'd be good to propose adding those attributes to numpy.finfo first, because it's not existing API and if NumPy doesn't want to extend finfo then we're better off leaving it out probably.

@rgommers
Copy link
Member Author

We discussed this, and because finfo comes from NumPy, moved the discussion there. PR close to being merged: numpy/numpy#18536

@rgommers
Copy link
Member Author

smallest_subnormal seems to be painful to get right, so not sure that should be included. But smallest_normal makes total sense I think.

@kgryte
Copy link
Contributor

kgryte commented Oct 4, 2021

This has been resolved. Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants