Skip to content

Update dtype strategies for elementwise/operators tests #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
honno opened this issue Jan 5, 2022 · 1 comment · Fixed by #62
Closed

Update dtype strategies for elementwise/operators tests #60

honno opened this issue Jan 5, 2022 · 1 comment · Fixed by #62
Assignees
@honno

Comments

@honno
Copy link
Member

honno commented Jan 5, 2022

Many of the elementwise/operator tests were written a while back, and there has been a lot of updates since in regards to what dtypes are allowed. This means we currently don't test all possible inputs!

Bug found today by @IvanYashchuk was numpy.array_api.pow() not working for integer arrays, probably because of the test suite was not updated with the spec.

So I'll need to review all the test methods to identify which aren't using all valid dtypes, and subsequently update them.
@honno honno self-assigned this Jan 5, 2022
@honno honno mentioned this issue Jan 6, 2022
Merged
@honno honno closed this as completed in #62 Jan 6, 2022
@honno honno reopened this Jan 7, 2022
@honno
Copy link
Member Author

honno commented Jan 11, 2022

data-apis/array-api#362 will resolve this issue

@honno honno closed this as completed Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honno honno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update divide and pow input dtypes honno/array-api-tests
1 participant
@honno