Skip to content

Remove test_type_promotion.py #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
honno opened this issue Sep 30, 2022 · 0 comments · Fixed by #155
Closed

Remove test_type_promotion.py #143

honno opened this issue Sep 30, 2022 · 0 comments · Fixed by #155

Comments

@honno
Copy link
Member

honno commented Sep 30, 2022

To summarise previous discussions as far as I can tell:

  • We want to test type promotion anyway in our primary tests.
  • There's still value of type promotion for developers of compliant libraries, given it pinpoints the issues.

The fact is though, I don't care about maintaining it. We already have a hacky conftest.py just to skip some flaky cases we identified, and I don't see it worth my time supporting complex cases. Testing type promotion isn't simple for a lot of functions, given other rules for inputs (namely broadcasting).

I think leaning on the primary tests solely is just a more sane approach anyway, as whilst bugs can sometimes be lost in the noise, they're usually getting reported and easier to identify once you fix other bugs you'll have to fix anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant