Skip to content

BUG: common: linalg.cholesky returns the conjugate of the expected upper decomposition #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucascolley opened this issue Aug 18, 2023 · 0 comments · Fixed by #61
Closed

BUG: common: linalg.cholesky returns the conjugate of the expected upper decomposition #54

lucascolley opened this issue Aug 18, 2023 · 0 comments · Fixed by #61
Labels
bug Something isn't working

Comments

@lucascolley
Copy link
Member

lucascolley commented Aug 18, 2023 •
edited
Loading

The same as numpy/numpy#24451, but for array_api_compat.cupy.

If I am correct about this being a bug, then I suspect that this is the line causing it:
https://github.com/data-apis/array-api-compat/blob/main/array_api_compat/common/_linalg.py#L58C47-L58C47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: common: fix cholesky upper decomp for complex dtypes lucascolley/array-api-compat
2 participants
@rgommers @lucascolley