chore: changes due to review

Author: daschaa

packages/parameters/src/ssm/SSMProvider.ts

@@ -837,12 +837,12 @@ class SSMProvider extends BaseProvider {
     options: SSMSetOptions
   ): Promise<number | undefined> {
     const sdkOptions: PutParameterCommandInput = {
-      Tier: options.tier || 'Standard',
-      Type: options.parameterType || 'String',
-      Overwrite: options.overwrite || false,
+      Tier: options.tier ?? 'Standard',
+      Type: options.parameterType ?? 'String',
+      Overwrite: options.overwrite ?? false,
       ...(options.kmsKeyId ? { KeyId: options.kmsKeyId } : {}),
       ...(options.description ? { Description: options.description } : {}),
-      ...(options?.sdkOptions || {}),
+      ...(options?.sdkOptions ?? {}),
       Name: name,
       Value: options.value,
     };

packages/parameters/src/ssm/setParameter.ts

@@ -1,5 +1,5 @@
 import { DEFAULT_PROVIDERS } from '../base/DefaultProviders.js';
-import type { SSMGetOptions, SSMSetOptions } from '../types/SSMProvider';
+import type { SSMSetOptions } from '../types/SSMProvider';
 import { SSMProvider } from './SSMProvider';
 
 /**

packages/parameters/tests/unit/SSMProvider.test.ts

@@ -1333,7 +1333,7 @@ describe('Class: SSMProvider', () => {
 
     test('returns undefined if version is undefined', async () => {
       const provider: SSMProvider = new SSMProvider();
-      const client = mockClient(SSMClient).on(PutParameterCommand).resolves({});
+      mockClient(SSMClient).on(PutParameterCommand).resolves({});
       const parameterName: string = '/my-parameter';
       const options: SSMSetOptions = { value: 'my-value' };
 
@@ -1365,7 +1365,7 @@ describe('Class: SSMProvider', () => {
 
     test('throws an error if setting a parameter fails', async () => {
       const provider: SSMProvider = new SSMProvider();
-      const client = mockClient(SSMClient)
+      mockClient(SSMClient)
         .on(PutParameterCommand)
         .rejects(new Error('Failed to set parameter'));
       const parameterName: string = '/my-parameter';