Skip to content

Commit c1ff8c9

Browse files
committed
Remove duplicate cancel and send real isolateid to reloadsources
1 parent 1559e0e commit c1ff8c9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

dwds/test/common/chrome_proxy_service_common.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2234,7 +2234,9 @@ void runTests({
22342234

22352235
test('reloadSources', () async {
22362236
final service = context.service;
2237-
final report = await service.reloadSources('');
2237+
final vm = await service.getVM();
2238+
final isolateId = vm.isolates!.first.id!;
2239+
final report = await service.reloadSources(isolateId);
22382240
// TODO(srujzs): This naturally fails regardless of the module format
22392241
// because we didn't set up prerequisite state (the reload scripts). We
22402242
// should create new tests for hot reload within DWDS and remove this

dwds/test/hot_reload_breakpoints_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,8 +436,6 @@ void main() {
436436
// Breakpoint should not be hit as it's now deleted. We should also see
437437
// the old string still as the closure has not been reevaluated.
438438
await callEvaluateAndExpectLog(oldCapturedString);
439-
440-
await consoleSubscription.cancel();
441439
});
442440
}, timeout: Timeout.factor(2));
443441

0 commit comments

Comments
 (0)