Skip to content

Commit f2e8464

Browse files
jakemac53Commit Queue
authored and
Commit Queue
committed
add newline after doc comments, add tests for doc comments
Bug: #55128 Change-Id: I6897e33ad291093d460e28a0b0f374d6504418e5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356260 Auto-Submit: Jake Macdonald <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent 0f1addd commit f2e8464

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

pkg/_fe_analyzer_shared/lib/src/macros/executor/builder_impls.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ DeclarationCode _buildFunctionAugmentation(
574574
assert(initializers == null || declaration is ConstructorDeclaration);
575575

576576
return new DeclarationCode.fromParts([
577-
if (docComments != null) docComments,
577+
if (docComments != null) ...[docComments, '\n'],
578578
if (declaration is MethodDeclaration) ' ',
579579
'augment ',
580580
if (declaration is ConstructorDeclaration) ...[

pkg/_fe_analyzer_shared/test/macros/executor/executor_test.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,7 @@ class LibraryInfo {
676676
expect(
677677
result.libraryAugmentations.single.debugString().toString(),
678678
equalsIgnoringWhitespace('''
679+
// A comment!
679680
augment String myFunction() {
680681
print('isExternal: false');
681682
print('isGetter: false');
@@ -733,6 +734,7 @@ class LibraryInfo {
733734
expect(
734735
result.libraryAugmentations.single.debugString().toString(),
735736
equalsIgnoringWhitespace('''
737+
// A comment!
736738
augment String get myVariable {
737739
print('isExternal: false');
738740
print('isGetter: true');
@@ -754,6 +756,7 @@ class LibraryInfo {
754756
expect(
755757
result.libraryAugmentations.single.debugString().toString(),
756758
equalsIgnoringWhitespace('''
759+
// A comment!
757760
augment void set myVariable(String value, ) {
758761
print('isExternal: false');
759762
print('isGetter: false');
@@ -1020,6 +1023,7 @@ final fieldDefinitionMatchers = [
10201023

10211024
final methodDefinitionMatchers = [
10221025
equalsIgnoringWhitespace('''
1026+
// A comment!
10231027
augment (String, bool? hello, {String world}) myMethod() {
10241028
print('definingClass: MyClass');
10251029
print('isExternal: false');
@@ -1050,6 +1054,7 @@ final methodDefinitionMatchers = [
10501054

10511055
final mixinMethodDefinitionMatchers = [
10521056
equalsIgnoringWhitespace('''
1057+
// A comment!
10531058
augment (String, bool? hello, {String world}) myMixinMethod() {
10541059
print('definingClass: MyMixin');
10551060
print('isExternal: false');

pkg/_fe_analyzer_shared/test/macros/executor/simple_macro.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,8 @@ class SimpleMacro
323323
@override
324324
Future<void> buildDefinitionForFunction(
325325
FunctionDeclaration function, FunctionDefinitionBuilder builder) async {
326-
builder.augment(await _buildFunctionAugmentation(function, builder));
326+
builder.augment(await _buildFunctionAugmentation(function, builder),
327+
docComments: CommentCode.fromString('// A comment!'));
327328
}
328329

329330
@override

0 commit comments

Comments
 (0)