Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Test failure #1370

Closed
vicb opened this issue Aug 19, 2014 · 6 comments
Closed

Test failure #1370

vicb opened this issue Aug 19, 2014 · 6 comments
Milestone

Comments

@vicb
Copy link
Contributor

vicb commented Aug 19, 2014

I have the following failure on current master

    Test failed: Caught Expected: 'INNER()'
      Actual: 'INNER(SHADOW-CONTENT)'
       Which: is different.
    Expected: INNER()
      Actual: INNER(SHADOW-CON ...

I think that this issue already occurred and was fixed, anybody any clue ?

@vicb vicb added the type: bug label Aug 19, 2014
@vicb vicb added this to the 0.14.0 milestone Aug 19, 2014
@vsavkin
Copy link
Contributor

vsavkin commented Aug 19, 2014

What version of Guinness are you using?

@vicb
Copy link
Contributor Author

vicb commented Aug 19, 2014

I have just updated > guinness 0.1.14 (was 0.1.9) but still have the failure

@rkirov
Copy link
Contributor

rkirov commented Aug 20, 2014

I saw the same failure yesterday, but it mysteriously went away. I tried a few things and something solved it, but don't remember which (updated dart, did a pub update, removed pubspec.lock, etc.)

Is it still happening?

@vsavkin
Copy link
Contributor

vsavkin commented Aug 20, 2014

I saw this failure when I fixed toHaveText.

In my case:

  1. One of the tests in compiler_spec was wrong.
  2. toHaveText did not work properly for shadow-full based components.

As a result, when I fixed toHaveText, the test started failing. So I fixed the test in #1290, but the branch hasn't been merged into master yet. That is why I asked about the version of Guinness, cause 0.1.14 has the new toHaveText.

Just checked out master. It is green. Can you still reproduce the issue?
Also, are you running tests in Firefox or Chrome?

@vicb
Copy link
Contributor Author

vicb commented Aug 21, 2014

On latest master (31dd24a)

  • works after a pub get (guinness is 0.1.9),
  • fails after a pub update (guiness is 0.1.14)

Tested on Dartium

@vsavkin
Copy link
Contributor

vsavkin commented Aug 21, 2014

It must be the same test I fixed in #1290.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants