Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Transformers should detect view templates #1322

Closed
vicb opened this issue Aug 7, 2014 · 6 comments
Closed

Transformers should detect view templates #1322

vicb opened this issue Aug 7, 2014 · 6 comments

Comments

@vicb
Copy link
Contributor

vicb commented Aug 7, 2014

ref #1279

View templates are not automatically detected by the transformers and should be manually added to the application pubspec.yaml.

We should add the detection of view templates in the transformers so that they do not have to be manually added to the pubspec.

@youssefgh
Copy link

Thats gonna be great ! maintaining the view templates up to date manually is hard for large set of views and also error prone 👍

@vicb
Copy link
Contributor Author

vicb commented Aug 11, 2014

Note: viewHtml is already supported. To support view (ie an file path) it should be better to wait for #1238 to get in.

@youssefgh
Copy link

Thanks for sharing, I'll keep an eye on the commit :)

@rkirov
Copy link
Contributor

rkirov commented Oct 9, 2014

#1238 is in.

@rkirov rkirov closed this as completed Oct 9, 2014
@vicb
Copy link
Contributor Author

vicb commented Oct 11, 2014

@rkirov #1238 being in does not fix the issue but was a req for this issue to gets fixed. Any interest in fixeing this for the 1.x branch ?

@rkirov
Copy link
Contributor

rkirov commented Oct 11, 2014

I see. There is always interest in fixing sharp edges like this. However, in terms of priorities minor issues with known workarounds are not top priority.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants