Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit e47fa6c

Browse files
rkirovjbdeboer
authored andcommitted
fix(directive-injector): wrong variable name in error thrown.
Add proper type annotation that would have caught the typo. Closes #1397
1 parent 7b7c7e7 commit e47fa6c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/core_dom/directive_injector.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ class DirectiveInjector implements DirectiveBinder {
324324
dynamic _new(Key k, List<Key> paramKeys, Function fn) {
325325
if (_constructionDepth > MAX_CONSTRUCTION_DEPTH) {
326326
_constructionDepth = NO_CONSTRUCTION;
327-
throw new DiCircularDependencyError(key);
327+
throw new DiCircularDependencyError(k);
328328
}
329329
bool isFirstConstruction = (_constructionDepth++ == NO_CONSTRUCTION);
330330
var oldTag = _TAG_GET.makeCurrent();
@@ -479,7 +479,7 @@ class ComponentDirectiveInjector extends DirectiveInjector {
479479
// For efficiency we run through the maximum resolving depth and unwind
480480
// instead of setting 'resolving' key per type.
481481
class DiCircularDependencyError extends ResolvingError {
482-
DiCircularDependencyError(key) : super(key);
482+
DiCircularDependencyError(Key key) : super(key);
483483

484484
// strips the cyclical part of the chain.
485485
List<Key> get stripCycle {

0 commit comments

Comments
 (0)