chore(benchmark): remove redundant getAverages method

Author: jeffbcross

benchmark/web/bp.js

@@ -17,7 +17,7 @@ bp.Statistics.getMean = function (sample) {
   var total = 0;
   sample.forEach(function(x) { total += x; });
   return total / sample.length;
-}
+};
 
 bp.Statistics.calculateConfidenceInterval = function(standardDeviation, sampleSize) {
   var standardError = standardDeviation / Math.sqrt(sampleSize);
@@ -143,6 +143,7 @@ bp.runTimedTest = function (bs) {
 };
 
 bp.runAllTests = function (done) {
+  var report;
   if (bp.runState.iterations--) {
     bp.steps.forEach(function(bs) {
       var testResults = bp.runTimedTest(bs);
@@ -151,14 +152,14 @@ bp.runAllTests = function (done) {
       bp.runState.recentGarbagePerStep[bs.name] = testResults.garbage;
       bp.runState.recentRetainedMemoryPerStep[bs.name] = testResults.retainedDelta;
     });
-    bp.report = bp.calcStats();
-    bp.writeReport(bp.report);
+    report = bp.calcStats();
+    bp.writeReport(report);
     window.requestAnimationFrame(function() {
       bp.runAllTests(done);
     });
   }
   else {
-    bp.writeReport(bp.report);
+    bp.writeReport(report);
     bp.resetIterations();
     done && done();
   }
@@ -184,15 +185,6 @@ bp.generateReportPartial = function(model) {
   return bp.infoTemplate(model);
 };
 
-bp.getAverages = function (times, gcTimes, garbageTimes, retainedTimes) {
-  return {
-    gcTime: bp.Statistics.getMean(gcTimes),
-    time: bp.Statistics.getMean(times),
-    garbage: bp.Statistics.getMean(garbageTimes),
-    retained: bp.Statistics.getMean(retainedTimes)
-  };
-};
-
 bp.writeReport = function(reportContent) {
   bp.infoDiv.innerHTML = reportContent;
 };
@@ -254,11 +246,13 @@ bp.calcStats = function() {
 
     tpa.nextEntry++;
     tpa.nextEntry %= bp.runState.numSamples;
-    avg = bp.getAverages(
-        tpa.times,
-        tpa.gcTimes,
-        tpa.garbageTimes,
-        tpa.retainedTimes);
+    avg = {
+      gcTime: bp.Statistics.getMean(tpa.gcTimes),
+      time: bp.Statistics.getMean(tpa.times),
+      garbage: bp.Statistics.getMean(tpa.garbageTimes),
+      retained: bp.Statistics.getMean(tpa.retainedTimes)
+    };
+
     timesStandardDeviation = bp.Statistics.calculateStandardDeviation(tpa.times, avg.time);
     timesConfidenceInterval = bp.Statistics.calculateConfidenceInterval(
         timesStandardDeviation,

benchmark/web/bp.spec.js

@@ -381,18 +381,6 @@ describe('bp', function() {
   });
 
 
-  describe('.getAverages()', function() {
-    it('should return the average of a set of numbers', function() {
-      expect(bp.getAverages([100,0,50,75,25], [2,4,2,4,3], [1,2],[3,4])).toEqual({
-        gcTime: 3,
-        time: 50,
-        garbage: 1.5,
-        retained: 3.5
-      });
-    });
-  });
-
-
   describe('.calcStats()', function() {
     beforeEach(function() {
       bp.steps = [mockStep];
@@ -435,13 +423,6 @@ describe('bp', function() {
     });
 
 
-    it('should call getAverages() with the correct info', function() {
-      var spy = spyOn(bp, 'getAverages').andCallThrough();
-      bp.calcStats();
-      expect(spy).toHaveBeenCalledWith([ 3, 7, 5 ], [ 1, 3, 2 ], [50,50,0.2], [25,25,0.1]);
-    });
-
-
     it('should set the most recent time for each step to the next entry', function() {
       bp.calcStats();
       expect(bp.runState.timesPerAction.fakeStep.times[2]).toBe(5);