fix(parser): Correctly distinguish NoSuchMethodError

When evaluating 'a.foo' we could get NoSuchMethodError
due to 'a' not having 'foo' or 'a' has 'foo' and
the getter throws NoSuchMethodError.

Fix #504

Author: mhevery

bin/parser_generator_for_spec.dart

@@ -90,6 +90,7 @@ main(arguments) {
       'a().name',
       'a[x()]()',
       'boo',
+      'getNoSuchMethod',
       '[].count(',
       'false',
       'false && run()',

lib/core/parser/eval_access.dart

@@ -89,10 +89,14 @@ abstract class AccessReflective {
       _cachedValue = mirror;
       return result;
     } on NoSuchMethodError catch (e) {
-      var result = createInvokeClosure(mirror, symbol);
-      if (result == null) rethrow;
-      _cachedKind = CACHED_VALUE;
-      return _cachedValue = result;
+      if (isNoSuchMethodDueToGetField(e)) {
+        var result = createInvokeClosure(mirror, symbol);
+        if (result == null) rethrow;
+        _cachedKind = CACHED_VALUE;
+        return _cachedValue = result;
+      } else {
+        rethrow;
+      }
     } on UnsupportedError catch (e) {
       var result = createInvokeClosure(mirror, symbol);
       if (result == null) rethrow;
@@ -101,6 +105,12 @@ abstract class AccessReflective {
     }
   }
 
+  bool isNoSuchMethodDueToGetField(NoSuchMethodError e) {
+    var msg = e.toString();
+    return msg.indexOf("has no instance getter '$name'.") != -1 || // Dart VM
+           msg.indexOf('Cannot call "$name\$') != -1; // Dart2JS
+  }
+
   _assign(scope, holder, value) {
     if (holder is Map) {
       holder[name] = value;

test/core/parser/parser_spec.dart

@@ -286,6 +286,13 @@ main() {
       });
 
 
+      it('should pass noSuchMethExceptions through getters', () {
+        expect(() {
+          parser('getNoSuchMethod').eval(new ScopeWithErrors());
+        }).toThrow("iDontExist");
+      });
+
+
       it('should pass exceptions through methods', () {
         expect(() {
           parser('foo()').eval(new ScopeWithErrors());
@@ -936,6 +943,7 @@ class BracketButNotMap {
 class ScopeWithErrors {
   String get boo { throw "boo to you"; }
   String foo() { throw "foo to you"; }
+  get getNoSuchMethod => null.iDontExist();
 }
 
 @NgFilter(name:'increment')