style: get ride of the for.length JS heritage

Closes #615

Author: vicb

lib/core/interpolate.dart

@@ -11,7 +11,7 @@ class Interpolation {
   String call(List parts, [_]) {
     if (parts == null) return seperators.join('');
     var str = [];
-    for (var i = 0, ii = parts.length; i < ii; i++) {
+    for (var i = 0; i < parts.length; i++) {
       str.add(seperators[i]);
       var value = parts[i];
       str.add(value == null ? '' : '$value');

lib/core/parser/eval.dart

@@ -11,7 +11,7 @@ class Chain extends syntax.Chain {
   Chain(List<syntax.Expression> expressions) : super(expressions);
   eval(scope, [FilterMap filters]) {
     var result;
-    for (int i = 0, length = expressions.length; i < length; i++) {
+    for (int i = 0; i < expressions.length; i++) {
       var last = expressions[i].eval(scope, filters);
       if (last != null) result = last;
     }

lib/core_dom/block.dart

@@ -78,9 +78,9 @@ class Block implements ElementWrapper {
     bool preventDefault = false;
 
     Function removeDomElements = () {
-      for (var j = 0, jj = elements.length; j < jj; j++) {
+      for (var j = 0; j < elements.length; j++) {
         dom.Node current = elements[j];
-        dom.Node next = j+1 < jj ? elements[j+1] : null;
+        dom.Node next = j+1 < elements.length ? elements[j+1] : null;
 
         while(next != null && current.nextNode != next) {
           current.nextNode.remove();

lib/core_dom/block_factory.dart

@@ -55,7 +55,7 @@ class BlockFactory {
     var preRenderedIndexOffset = 0;
     var directiveDefsByName = {};
 
-    for (int i = 0, ii = directivePositions.length; i < ii;) {
+    for (int i = 0; i < directivePositions.length;) {
       int index = directivePositions[i++];
 
       List<DirectiveRef> directiveRefs = directivePositions[i++];

lib/core_dom/compiler.dart

@@ -26,7 +26,7 @@ class Compiler {
 
       cursorAlreadyAdvanced = false;
 
-      for (var j = 0, jj = declaredDirectiveRefs.length; j < jj; j++) {
+      for (var j = 0; j < declaredDirectiveRefs.length; j++) {
         DirectiveRef directiveRef = declaredDirectiveRefs[j];
         NgAnnotation annotation = directiveRef.annotation;
         var blockFactory = null;
@@ -42,11 +42,11 @@ class Compiler {
               domCursor, templateCursor,
               directiveRef, remainingDirectives, directives);
 
-          j = jj; // stop processing further directives since they belong to transclusion;
-        }
-        if (usableDirectiveRefs == null) {
-          usableDirectiveRefs = [];
+          // stop processing further directives since they belong to
+          // transclusion
+          j = declaredDirectiveRefs.length;
         }
+        if (usableDirectiveRefs == null) usableDirectiveRefs = [];
         directiveRef.blockFactory = blockFactory;
         createMappings(directiveRef);
         usableDirectiveRefs.add(directiveRef);

lib/core_dom/node_cursor.dart

@@ -75,7 +75,7 @@ class NodeCursor {
   remove() {
     var nodes = nodeList();
 
-    for (var i = 0, ii = nodes.length; i < ii; i++) {
+    for (var i = 0; i <  nodes.length; i++) {
       // NOTE(deboer): If elements is a list of child nodes on a node, then
       // calling Node.remove() may also remove it from the list.  Thus, we
       // call elements.removeAt first so only one node is removed.

lib/directive/input_select.dart

@@ -140,8 +140,8 @@ class _SelectMode {
 
   get _options => select.querySelectorAll('option');
   _forEachOption(fn, [quiteOnReturn = false]) {
-    for (var os = _options, i = 0, ii = os.length; i < ii; i++) {
-      var retValue = fn(os[i], i);
+    for (var i = 0; i < _options.length; i++) {
+      var retValue = fn(_options[i], i);
       if (quiteOnReturn && retValue != null) return retValue;
     }
     return null;

lib/directive/ng_repeat.dart

@@ -107,6 +107,7 @@ class NgRepeatDirective extends AbstractNgRepeatDirective {
  *  digest cycle and will not update on changes to the model.
  *
  */
+@deprecated
 @NgDirective(
     children: NgAnnotation.TRANSCLUDE_CHILDREN,
     selector: '[ng-shallow-repeat]',
@@ -120,7 +121,7 @@ class NgShallowRepeatDirective extends AbstractNgRepeatDirective {
                           AstParser astParser)
       : super(blockHole, boundBlockFactory, scope, parser, astParser)
   {
-    print('DEPRICATED: [ng-shallow-repeat] use [ng-repeat]');
+    print('DEPRECATED: [ng-shallow-repeat] use [ng-repeat]');
   }
 }
 
@@ -218,7 +219,7 @@ abstract class AbstractNgRepeatDirective  {
       }
     }
     // remove existing items
-    _rows.forEach((key, row){
+    _rows.forEach((key, row) {
       row.block.remove();
       row.scope.destroy();
     });
@@ -236,7 +237,7 @@ abstract class AbstractNgRepeatDirective  {
 
     List<_Row> newRowOrder = _computeNewRows(collection, trackById);
 
-    for (var index = 0, length = collection.length; index < length; index++) {
+    for (var index = 0; index < collection.length; index++) {
       var value = collection.elementAt(index);
       _Row row = newRowOrder[index];
 
@@ -263,14 +264,14 @@ abstract class AbstractNgRepeatDirective  {
         childContext[_valueIdentifier] = value;
       }
       var first = (index == 0);
-      var last = (index == (length - 1));
+      var last = (index == collection.length - 1);
       childContext
-        ..[r'$index'] = index
-        ..[r'$first'] = (index == 0)
-        ..[r'$last'] = (index == (length - 1))
-        ..[r'$middle'] = !first && !last
-        ..[r'$odd'] = index & 1 == 1
-        ..[r'$even'] = index & 1 == 0;
+          ..[r'$index'] = index
+          ..[r'$first'] = first
+          ..[r'$last'] = last
+          ..[r'$middle'] = !first && !last
+          ..[r'$odd'] = index & 1 == 1
+          ..[r'$even'] = index & 1 == 0;
 
       if (row.startNode == null) {
         var block = _boundBlockFactory(childScope);

test/jasmine_syntax.dart

@@ -1,4 +1,4 @@
-library jamine;
+library jasmine;
 
 import 'package:unittest/unittest.dart' as unit;
 import 'package:angular/utils.dart' as utils;