Revert "feat(compiler): support ScopeAware for decorators"

This reverts commit 9659dd1.

Wrong version of this PR was added in master, correct version is in
g3v1x.

Author: rkirov

lib/core/scope.dart

@@ -110,29 +110,28 @@ class ScopeLocals implements Map {
 }
 
 /**
- * When a [Directive] or the root context class implements [ScopeAware] the scope
- * setter will be called to set the [Scope] on this component.
+ * When a [Component] or the root context class implements [ScopeAware] the scope setter will be
+ * called to set the [Scope] on this component.
  *
- * The order of calls is as follows:
- * - [Component] instance is created.
- * - [Scope] instance is created (taking [Component] instance as evaluation context).
- * - if [Component] is [ScopeAware], set scope method is called with scope instance.
+ * Typically classes implementing [ScopeAware] will declare a `Scope scope` property which will get
+ * initialized after the [Scope] is available. For this reason the `scope` property will not be
+ * initialized during the execution of the constructor - it will be immediately after.
  *
- * [ScopeAware] is guaranteed to be called before [AttachAware] or [DetachAware] methods.
+ * However, if you need to execute some code as soon as the scope is available you should implement
+ * a `scope` setter:
  *
- * Example:
  *     @Component(...)
  *     class MyComponent implements ScopeAware {
  *       Watch watch;
  *
  *       MyComponent(Dependency myDep) {
- *         // It is an error to add a Scope argument to the ctor and will result in a DI
- *         // circular dependency error - the scope has a dependency on the component instance.
+ *         // It is an error to add a Scope / RootScope argument to the ctor and will result in a DI
+ *         // circular dependency error - the scope is never accessible in the class constructor
  *       }
  *
  *       void set scope(Scope scope) {
  *          // This setter gets called to initialize the scope
- *          watch = scope.watch("expression", (v, p) => ...);
+ *          watch = scope.rootScope.watch("expression", (v, p) => ...);
  *       }
  *     }
  */

lib/core_dom/element_binder.dart

@@ -226,8 +226,6 @@ class ElementBinder {
           _createAttrMappings(directive, scope, ref.mappings, nodeAttrs, tasks);
         }
 
-        if (directive is ScopeAware) directive.scope = scope;
-
         if (directive is AttachAware) {
           var taskId = (tasks != null) ? tasks.registerTask() : 0;
           Watch watch;

lib/core_dom/shadow_dom_component_factory.dart

@@ -145,6 +145,7 @@ class BoundShadowDomComponentFactory implements BoundComponentFactory {
         }
 
         var controller = shadowInjector.getByKey(_ref.typeKey);
+        if (controller is ScopeAware) controller.scope = shadowScope;
         BoundComponentFactory._setupOnShadowDomAttach(controller, templateLoader, shadowScope);
         shadowScope.context[_component.publishAs] = controller;
 

lib/core_dom/transcluding_component_factory.dart

@@ -114,6 +114,7 @@ class BoundTranscludingComponentFactory implements BoundComponentFactory {
 
       var controller = childInjector.getByKey(_ref.typeKey);
       shadowScope.context[component.publishAs] = controller;
+      if (controller is ScopeAware) controller.scope = shadowScope;
       BoundComponentFactory._setupOnShadowDomAttach(controller, templateLoader, shadowScope);
       return controller;
     };

test/core_dom/compiler_spec.dart

@@ -1072,14 +1072,6 @@ void main() {
 
         expect(log.result()).toEqual('Scope set');
       }));
-
-      it('should call scope setter on ScopeAware decorators', async((TestBed _, Logger log) {
-        var element = _.compile('<div scope-aware-dec></div>');
-
-        _.rootScope.apply();
-
-        expect(log.result()).toEqual('Scope set');
-      }));
     });
 
 
@@ -1555,9 +1547,6 @@ class SameNameDecorator {
 @Component(
     selector: 'scope-aware-cmp'
 )
-@Decorator(
-    selector: '[scope-aware-dec]'
-)
 class ScopeAwareComponent implements ScopeAware {
   Logger log;
   ScopeAwareComponent(this.log) {}