refactor(tests): remove unnecessary inject calls

Some tests rely on the fact that dependencies can be injected into `it`s, but some call `inject` explicitly. This PR makes tests more consistent by removing unnecessary inject calls.

Closes #1218

Author: vsavkin

test/animate/animation_loop_spec.dart

@@ -8,11 +8,11 @@ main() {
     TestBed _;
     AnimationLoop runner;
     MockAnimationFrame frame;
-    beforeEach(async(inject((TestBed tb, VmTurnZone zone) {
+    beforeEach(async((TestBed tb, VmTurnZone zone) {
       _ = tb;
       frame = new MockAnimationFrame();
       runner = new AnimationLoop(frame, new Profiler(), zone);
-    })));
+    }));
 
     it('should play animations with window animation frames', async(() {
       var animation = new MockAnimation();

test/animate/animation_optimizer_spec.dart

@@ -7,10 +7,10 @@ _run({bool animationsAllowed}) {
   describe('animationsAllowed=$animationsAllowed', () {
     TestBed _;
     AnimationOptimizer optimizer;
-    beforeEach(inject((TestBed tb, Expando expand) {
+    beforeEach((TestBed tb, Expando expand) {
       _ = tb;
       optimizer = new AnimationOptimizer(expand)..animationsAllowed = animationsAllowed;
-    }));
+    });
 
     it('should prevent animations on child elements', () {
       var animation = new NoOpAnimation();

test/animate/css_animate_spec.dart

@@ -11,13 +11,13 @@ _run({bool animationsAllowed}) {
     Animate animate;
     MockAnimationLoop runner;
 
-    beforeEach(inject((TestBed tb, Expando expand) {
+    beforeEach((TestBed tb, Expando expand) {
       _ = tb;
       runner = new MockAnimationLoop(animationsAllowed);
       animate = new CssAnimate(runner,
           new CssAnimationMap(), new AnimationOptimizer(expand));
       animate.animationsAllowed = animationsAllowed;
-    }));
+    });
 
     it('should add a css class to an element node', async(() {
       _.compile('<div></div>');

test/animate/css_animation_spec.dart

@@ -6,7 +6,7 @@ main() {
   describe('CssAnimation', () {
     TestBed _;
 
-    beforeEach(inject((TestBed tb) => _ = tb));
+    beforeEach((TestBed tb) => _ = tb);
     afterEach(() => _.rootElements.forEach((e) => e.remove()));
 
     it('should correctly respond to an animation lifecycle', async(() {

test/cache/cache_spec.dart

@@ -67,17 +67,17 @@ void main() {
 
       describe('put, get & remove', () {
 
-        it('should add cache entries via add and retrieve them via get', inject(() {
+        it('should add cache entries via add and retrieve them via get', () {
           var obj = {'bar':'baz'};
           cache.put('key1', 'bar');
           cache.put('key2', obj);
 
           expect(cache.get('key2')).toBe(obj);
           expect(cache.get('key1')).toBe('bar');
-        }));
+        });
 
 
-        it('should remove entries via remove', inject(() {
+        it('should remove entries via remove', () {
           cache.put('k1', 'foo');
           cache.put('k2', 'bar');
 
@@ -90,22 +90,22 @@ void main() {
 
           expect(cache.get('k1')).toBeNull();
           expect(cache.get('k2')).toBeNull();
-        }));
+        });
 
 
-        it('should return null when entry does not exist', inject(() {
+        it('should return null when entry does not exist', () {
           expect(cache.remove('non-existent')).toBeNull();
-        }));
+        });
 
-        it("should return value from put", inject(() {
+        it("should return value from put", () {
           var obj = {};
           expect(cache.put('k1', obj)).toBe(obj);
-        }));
+        });
       });
 
 
       describe('removeAll', () {
-        it('should blow away all data', inject(() {
+        it('should blow away all data', () {
           cache.put('id1', 1);
           cache.put('id2', 2);
           cache.put('id3', 3);
@@ -115,13 +115,13 @@ void main() {
           expect(cache.get('id1')).toBeNull();
           expect(cache.get('id2')).toBeNull();
           expect(cache.get('id3')).toBeNull();
-        }));
+        });
       });
     });
 
     // TODO(chirayu): Add a lot more tests and tests and don't rely on toString()
     describe('LRU cache', () {
-      it('should have LRU behavior with ordering keys and eviction', inject(() {
+      it('should have LRU behavior with ordering keys and eviction', () {
         var cache = new LruCache<int, int>(capacity: 4);
         cache.put(1, 10);
         cache.put(2, 20);
@@ -146,7 +146,7 @@ void main() {
         expect(stats.size).toEqual(0);
         expect(stats.hits).toEqual(2);
         expect(stats.misses).toEqual(1);
-      }));
+      });
 
       it('should hold nothing if capacity is zero', () {
         var cache = new LruCache<int, int>(capacity: 0);

test/change_detection/watch_group_spec.dart

@@ -23,15 +23,15 @@ void main() {
     Parser parser;
     ASTParser astParser;
 
-    beforeEach(inject((Logger _logger, Parser _parser, ASTParser _astParser) {
+    beforeEach((Logger _logger, Parser _parser, ASTParser _astParser) {
       context = {};
       var getterFactory = new DynamicFieldGetterFactory();
       changeDetector = new DirtyCheckingChangeDetector(getterFactory);
       watchGrp = new RootWatchGroup(getterFactory, changeDetector, context);
       logger = _logger;
       parser = _parser;
       astParser = _astParser;
-    }));
+    });
 
     AST parse(String expression) => astParser(expression);
 
@@ -64,13 +64,13 @@ void main() {
       expect(logger).toEqual(list);
     }
 
-    beforeEach(inject((Logger _logger) {
+    beforeEach((Logger _logger) {
       context = {};
       var getterFactory = new DynamicFieldGetterFactory();
       changeDetector = new DirtyCheckingChangeDetector(getterFactory);
       watchGrp = new RootWatchGroup(getterFactory, changeDetector, context);
       logger = _logger;
-    }));
+    });
 
     it('should have a toString for debugging', () {
       watchGrp.watch(parse('a'), (v, p) {});

test/core/scope_spec.dart

@@ -654,7 +654,7 @@ void main() {
 
 
           it('should skip scopes which dont have given event',
-          inject((RootScope rootScope, Logger log) {
+          (RootScope rootScope, Logger log) {
             var child1 = rootScope.createChild('A');
             rootScope.createChild('A1');
             rootScope.createChild('A2');
@@ -663,7 +663,7 @@ void main() {
             child2.on('event').listen((e) => log(e.data));
             rootScope.broadcast('event', 'OK');
             expect(log).toEqual(['OK']);
-          }));
+          });
         });
 
 
@@ -847,14 +847,14 @@ void main() {
         });
 
 
-        it(r'should execute and return value and update', inject(
-                (RootScope rootScope, ExceptionHandler e) {
-              LoggingExceptionHandler exceptionHandler = e;
-              rootScope.context['name'] = 'abc';
-              expect(rootScope.apply((context) => context['name'])).toEqual('abc');
-              expect(log).toEqual('digest;digest;');
-              exceptionHandler.assertEmpty();
-            }));
+        it(r'should execute and return value and update',
+            (RootScope rootScope, ExceptionHandler e) {
+          LoggingExceptionHandler exceptionHandler = e;
+          rootScope.context['name'] = 'abc';
+          expect(rootScope.apply((context) => context['name'])).toEqual('abc');
+          expect(log).toEqual('digest;digest;');
+          exceptionHandler.assertEmpty();
+        });
 
 
         it(r'should execute and return value and update', (RootScope rootScope) {
@@ -924,14 +924,14 @@ void main() {
           exceptionHandler.assertEmpty();
         });
 
-        it(r'should execute and return value and update', inject(
-                (RootScope rootScope, ExceptionHandler e) {
-              LoggingExceptionHandler exceptionHandler = e;
-              rootScope.context['name'] = 'abc';
-              expect(rootScope.apply((context) => context['name'])).toEqual('abc');
-              expect(log).toEqual('digest;digest;');
-              exceptionHandler.assertEmpty();
-            }));
+        it(r'should execute and return value and update',
+            (RootScope rootScope, ExceptionHandler e) {
+          LoggingExceptionHandler exceptionHandler = e;
+          rootScope.context['name'] = 'abc';
+          expect(rootScope.apply((context) => context['name'])).toEqual('abc');
+          expect(log).toEqual('digest;digest;');
+          exceptionHandler.assertEmpty();
+        });
 
         it(r'should execute and return value and update', (RootScope rootScope) {
           rootScope.context['name'] = 'abc';
@@ -1092,23 +1092,22 @@ void main() {
       });
 
 
-      it(r'should run digest multiple times', inject(
-              (RootScope rootScope) {
-            // tests a traversal edge case which we originally missed
-            var log = [];
-            var childA = rootScope.createChild({'log': log});
-            var childB = rootScope.createChild({'log': log});
+      it(r'should run digest multiple times', (RootScope rootScope) {
+        // tests a traversal edge case which we originally missed
+        var log = [];
+        var childA = rootScope.createChild({'log': log});
+        var childB = rootScope.createChild({'log': log});
 
-            rootScope.context['log'] = log;
+        rootScope.context['log'] = log;
 
-            rootScope.watch("log.add('r')", (_, __) => null);
-            childA.watch("log.add('a')", (_, __) => null);
-            childB.watch("log.add('b')", (_, __) => null);
+        rootScope.watch("log.add('r')", (_, __) => null);
+        childA.watch("log.add('a')", (_, __) => null);
+        childB.watch("log.add('b')", (_, __) => null);
 
-            // init
-            rootScope.digest();
-            expect(log.join('')).toEqual('rabrab');
-          }));
+        // init
+        rootScope.digest();
+        expect(log.join('')).toEqual('rabrab');
+      });
 
 
       it(r'should repeat watch cycle while model changes are identified', (RootScope rootScope) {
@@ -1165,7 +1164,7 @@ void main() {
       });
 
 
-      it(r'should return a function that allows listeners to be unregistered', inject(
+      it(r'should return a function that allows listeners to be unregistered',
           (RootScope rootScope) {
         var listener = guinness.createSpy('watch listener');
         var watch;
@@ -1185,7 +1184,7 @@ void main() {
         watch.remove();
         rootScope.digest(); //trigger
         expect(listener).not.toHaveBeenCalled();
-      }));
+      });
 
 
       it(r'should be possible to remove every watch',
@@ -1242,7 +1241,7 @@ void main() {
 
 
       it(r'should always call the watchr with newVal and oldVal equal on the first run',
-      inject((RootScope rootScope) {
+          (RootScope rootScope) {
         var log = [];
         var logger = (newVal, oldVal) {
           var val = (newVal == oldVal || (newVal != oldVal && oldVal != newVal)) ? newVal : 'xxx';
@@ -1267,7 +1266,7 @@ void main() {
         log = [];
         rootScope.digest();
         expect(log).toEqual([]);
-      }));
+      });
 
 
       it('should properly watch constants', (RootScope rootScope, Logger log) {