Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit 356df76

Browse files
kasperlmhevery
authored andcommitted
chore(dart2js): Re-enable tests that were disabled because of V8 bug in Chrome 33.
Closes #878
1 parent c73a0c7 commit 356df76

File tree

4 files changed

+24
-31
lines changed

4 files changed

+24
-31
lines changed

pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ packages:
7171
route_hierarchical:
7272
description: route_hierarchical
7373
source: hosted
74-
version: "0.4.15"
74+
version: "0.4.18"
7575
shadow_dom:
7676
description: shadow_dom
7777
source: hosted

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ dependencies:
2323
html5lib: '>=0.9.2 <0.10.0'
2424
intl: '>=0.8.7 <0.10.0'
2525
perf_api: '>=0.0.8 <0.1.0'
26-
route_hierarchical: '>=0.4.7 <0.5.0'
26+
route_hierarchical: '>=0.4.18 <0.5.0'
2727
shadow_dom: '>=0.9.1 <1.0.0'
2828
dev_dependencies:
2929
benchmark_harness: '>=1.0.0'

test/routing/ng_view_spec.dart

Lines changed: 22 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -101,33 +101,28 @@ main() {
101101
'<h2>Read Book 1234</h2>'));
102102
});
103103

104-
// This test is disable on dart2js because it is flaky
105-
// on dart v1.2. Kasper is looking into it. In the
106-
// meantime we are disabling it.
107-
if (!identical(1, 1.0)) {
108-
it('should switch nested templates', async(() {
109-
Element root = _.compile('<ng-view></ng-view>');
110-
expect(root.text).toEqual('');
111-
112-
router.route('/library/all');
113-
microLeap();
114-
expect(root.text).toEqual('LibraryBooks');
115-
116-
router.route('/library/1234');
117-
microLeap();
118-
expect(root.text).toEqual('LibraryBook 1234');
119-
120-
// nothing should change here
121-
router.route('/library/1234/overview');
122-
microLeap();
123-
expect(root.text).toEqual('LibraryBook 1234');
124-
125-
// nothing should change here
126-
router.route('/library/1234/read');
127-
microLeap();
128-
expect(root.text).toEqual('LibraryRead Book 1234');
129-
}));
130-
}
104+
it('should switch nested templates', async(() {
105+
Element root = _.compile('<ng-view></ng-view>');
106+
expect(root.text).toEqual('');
107+
108+
router.route('/library/all');
109+
microLeap();
110+
expect(root.text).toEqual('LibraryBooks');
111+
112+
router.route('/library/1234');
113+
microLeap();
114+
expect(root.text).toEqual('LibraryBook 1234');
115+
116+
// nothing should change here
117+
router.route('/library/1234/overview');
118+
microLeap();
119+
expect(root.text).toEqual('LibraryBook 1234');
120+
121+
// nothing should change here
122+
router.route('/library/1234/read');
123+
microLeap();
124+
expect(root.text).toEqual('LibraryRead Book 1234');
125+
}));
131126
});
132127
}
133128

test/routing/routing_spec.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import 'package:angular/angular_dynamic.dart';
66
import 'dart:async';
77

88
main() {
9-
// Do not run in dart2js until the exception is fixed
10-
if (identical(1.0, 1)) return;
119
describe('routing', () {
1210
TestBed _;
1311
Router router;

0 commit comments

Comments
 (0)