Put pubspec.lock under source control

[vicb]

As angular is moving really fast, users encounter issues trying the examples.

Versionning the lock file could help them by making sure that the dependencies are at a working version.

[savantmohan]

@vicb :

What could be possible solution for this. Kindly explain in detail as i am new to angular dart environment.

[zoechi]

see also http://stackoverflow.com/questions/22040348/

[savantmohan]

@zoechi That issue was posted by me only :)

[vicb]

@savantmohan there's probably a problem with version mismatch that comes form pubspec.lock not being versionned. This is what is requested by the linked issue. There's really nothing we can do in this repo for that.

Edit: I thought I was posting in angular.dart..., here is the right place

[zoechi]

@savantmohan I know. I just wanted to connect them.

[kwalrath]

Would it work to just change pubspec.yaml to have a specific version, rather than "any"?

[vicb]

the .lock file has more versions (includes dependencies) so having the lock file versionned is really the best bet.

[kwalrath]

@mhevery, @traceypowersg, @shailen: What's your opinion on putting the AngularDart tutorial's pubspec.lock under version control? At the very least, we should change pubspec.yaml to have a specific version of angular, but @vicb thinks that's not enough.

[vicb]

@kwalrath this page has some useful information and the linked session states:

If your package is for an app, you check your lockfile into your source control system! That way, everyone on your team will be using the exact same versions of every dependency when they build your app.

edit:
and towards the end, there's an explanation of why concrete versions in pubspec.yaml is a bad idea:

But depending on single concrete versions is too precise and with shared dependencies leads to version lock.

[kwalrath]

@vicb, I even wrote something about that (way back when): https://www.dartlang.org/tools/private-files.html#pubspeclock

OK, you're right, we should check in pubspec.lock. And have someone responsible for updating it from time to time.

[kwalrath]

Any volunteers? :)

[vicb]

I would love to see angular adopting semver, see dart-archive/angular.dart#612

This way it would be easier to upgrade the lock files on BC breaks... But I guess pre-1.0 every single version might break BC.

[vicb]

@kwalrath I think you should open a ticket. You'll probably be able to find a volunteer in the community.

[kwalrath]

Fixed. Thanks, @vicb!