fix: can handle v prefix in the GH release name

Ref: arduino/arduino-cli#2374

Signed-off-by: dankeboy36 <[email protected]>

Author: dankeboy36

Diff for: package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "install-from-gh-to-vscode",
-  "version": "0.1.0-beta.8",
+  "version": "0.1.0-beta.9",
   "description": "Lib for VS Code extensions installing executables from GitHub",
   "main": "out/src/index.js",
   "types": "out/src/index.d.ts",
@@ -27,7 +27,8 @@
     "test": "tsc -p ./ && tape -r source-map-support/register 'out/test/**/*.js' | tap-spec",
     "format": "clang-format -i --glob=\"{src,test}/**/*.ts\"",
     "git-clang-format": "git-clang-format",
-    "prepare": "npm run test && npm run format && tsc -p ./"
+    "prepare": "npm run test && npm run format && tsc -p ./",
+    "example": "ts-node ./src/example/index.ts"
   },
   "dependencies": {
     "abort-controller": "^3.0.0",
@@ -58,6 +59,7 @@
     "tap-spec": "^5.0.0",
     "tape": "^5.0.0",
     "tmp-promise": "^2.1.0",
+    "ts-node": "^10.9.1",
     "typescript": "^3.8.3"
   }
 }

Diff for: package.json

@@ -24,14 +24,15 @@ class Noop implements UI {
 
 const arduinoCliOptions: Options = {
   // pinned version range
-  versionRange: '<=0.27.0',
+  versionRange: '<=v0.35.0-rc.7',
   gh: {owner: 'arduino', repo: 'arduino-cli'},
   executableName: 'arduino-cli',
   versionFlags: ['version', '--format', 'json'],
   parseVersion(output: string):
       string { return JSON.parse(output.trim()).VersionString; },
   async pickAsset(assetNames: string[]): Promise<number> {
-    return 6; // 'arduino-cli_0.27.0_macOS_64bit.tar.gz'
+    // console.log(assetNames[7]); // arduino-cli_0.35.0-rc.7_macOS_64bit.tar.gz
+    return 7;
   }
 };
 

Diff for: src/example/index.ts

@@ -285,7 +285,8 @@ async function latestCompatibleVersion(ui: UI): Promise<string|undefined> {
                    .reverse();
   for (const tag of tags) {
     if (versionConstrains.test(tag)) {
-      return tag.version;
+      return tag.raw; // use the raw semver string
+                      // https://github.com/arduino/arduino-cli/pull/2374
     }
   }
   throw new Error(`Could not find a compatible version for ${