Skip to content

Commit f1171ac

Browse files
committed
#426: Added file numbers to class report
2 parents 241db67 + 3f6fb3a commit f1171ac

File tree

4 files changed

+22
-5
lines changed

4 files changed

+22
-5
lines changed

src/Readme.txt

+4
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ For further details take a look at LICENSE.txt.
6464

6565
CHANGELOG
6666

67+
4.8.11.0
68+
69+
* New: #426: Added file numbers to class report
70+
6771
4.8.10.0
6872

6973
* New: #431: Added Markdown output format

src/ReportGenerator.Core/Properties/ReportResources.Designer.cs

+10-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ReportGenerator.Core/Properties/ReportResources.resx

+3
Original file line numberDiff line numberDiff line change
@@ -345,4 +345,7 @@
345345
<data name="StarTooltip" xml:space="preserve">
346346
<value>Star on GitHub</value>
347347
</data>
348+
<data name="File" xml:space="preserve">
349+
<value>File</value>
350+
</data>
348351
</root>

src/ReportGenerator.Core/Reporting/Builders/Rendering/HtmlRenderer.cs

+5-4
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ public void TestMethods(IEnumerable<TestMethod> testMethods, IEnumerable<FileAna
298298
item.Key,
299299
codeElement.FirstLine,
300300
codeElement.CoverageQuota.HasValue ? coverageRounded.ToString() : "undefined",
301-
codeElement.CoverageQuota.HasValue ? ReportResources.Coverage2 + " " + codeElement.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "% - " : string.Empty,
301+
$"{ReportResources.File} {item.Key + 1}: " + (codeElement.CoverageQuota.HasValue ? ReportResources.Coverage2 + " " + codeElement.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "% - " : string.Empty),
302302
WebUtility.HtmlEncode(codeElement.Name),
303303
codeElement.CodeElementType == CodeElementType.Method ? "cube" : "wrench");
304304
}
@@ -626,7 +626,8 @@ public void KeyValueRow(string key, string value)
626626
/// <param name="files">The files.</param>
627627
public void KeyValueRow(string key, IEnumerable<string> files)
628628
{
629-
string value = string.Join("<br />", files.Select(v => string.Format(CultureInfo.InvariantCulture, "<a href=\"#{0}\" class=\"navigatetohash\">{1}</a>", WebUtility.HtmlEncode(StringHelper.ReplaceNonLetterChars(v)), WebUtility.HtmlEncode(v))));
629+
int fileNumber = 1;
630+
string value = string.Join("<br />", files.Select(v => string.Format(CultureInfo.InvariantCulture, "<a href=\"#{0}\" class=\"navigatetohash\">{1}</a>", WebUtility.HtmlEncode(StringHelper.ReplaceNonLetterChars(v)), WebUtility.HtmlEncode($"{ReportResources.File} {fileNumber++}: " + v))));
630631

631632
this.reportTextWriter.WriteLine(
632633
"<tr><th>{0}</th><td>{1}</td></tr>",
@@ -686,11 +687,11 @@ public void MetricsTable(Class @class)
686687
WebUtility.HtmlEncode(methodMetric.FullName),
687688
fileIndex,
688689
methodMetric.Line,
689-
WebUtility.HtmlEncode(methodMetric.ShortName));
690+
WebUtility.HtmlEncode($"{ReportResources.File} {fileIndex + 1}: " + methodMetric.ShortName));
690691
}
691692
else
692693
{
693-
this.reportTextWriter.Write("<td title=\"{0}\">{1}</td>", WebUtility.HtmlEncode(methodMetric.FullName), WebUtility.HtmlEncode(methodMetric.ShortName));
694+
this.reportTextWriter.Write("<td title=\"{0}\">{1}</td>", WebUtility.HtmlEncode(methodMetric.FullName), WebUtility.HtmlEncode(file.Path + " => " + methodMetric.ShortName));
694695
}
695696

696697
foreach (var metric in metrics)

0 commit comments

Comments
 (0)