Skip to content

Commit c3c0838

Browse files
danielpalmedanielpalme
committed
#392: Filters are now case insensitive
1 parent 11c2692 commit c3c0838

File tree

14 files changed

+36
-19
lines changed

14 files changed

+36
-19
lines changed

‎azure-pipelines.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ variables:
1212
- name: disable.coverage.autogenerate
1313
value: 'true'
1414
- name: version
15-
value: '4.7.0'
15+
value: '4.7.1'
1616

1717
stages:
1818
- stage: Build

‎src/AzureDevopsTask/ReportGenerator/task.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"version": {
1414
"Major": 4,
1515
"Minor": 7,
16-
"Patch": 0
16+
"Patch": 1
1717
},
1818
"instanceNameFormat": "ReportGenerator",
1919
"groups": [

‎src/AzureDevopsTask/vss-extension.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"manifestVersion": 1,
33
"id": "reportgenerator",
44
"name": "ReportGenerator",
5-
"version": "4.7.0",
5+
"version": "4.7.1",
66
"publisher": "Palmmedia",
77
"public": true,
88
"targets": [

‎src/Readme.txt

+4
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ For further details take a look at LICENSE.txt.
6363

6464
CHANGELOG
6565

66+
4.7.1.0
67+
68+
* New: #392: Filters are now case insensitive
69+
6670
4.7.0.0
6771

6872
* New: Dropped support for Nuget package 'dotnet-reportgenerator-cli'. Use 'dotnet-reportgenerator-globaltool' instead.

‎src/ReportGenerator.Console.NetCore/ReportGenerator.Console.NetCore.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<AssemblyName>ReportGenerator</AssemblyName>
88
<RootNamespace>Palmmedia.ReportGenerator</RootNamespace>
99
<StartupObject>Palmmedia.ReportGenerator.Console.NetCore.Program</StartupObject>
10-
<AssemblyVersion>4.7.0.0</AssemblyVersion>
11-
<FileVersion>4.7.0.0</FileVersion>
10+
<AssemblyVersion>4.7.1.0</AssemblyVersion>
11+
<FileVersion>4.7.1.0</FileVersion>
1212
</PropertyGroup>
1313

1414
<ItemGroup>

‎src/ReportGenerator.Console/Properties/AssemblyInfo.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@
3131
// You can specify all the values or you can default the Build and Revision Numbers
3232
// by using the '*' as shown below:
3333
// [assembly: AssemblyVersion("1.0.*")]
34-
[assembly: AssemblyVersion("4.7.0.0")]
35-
[assembly: AssemblyFileVersion("4.7.0.0")]
34+
[assembly: AssemblyVersion("4.7.1.0")]
35+
[assembly: AssemblyFileVersion("4.7.1.0")]

‎src/ReportGenerator.Core.Test/Parser/Filtering/DefaultFilterTest.cs

+13
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public void NoFilter_AnyElement_ElementIsAccepted()
1515
IFilter filter = new DefaultFilter(new string[] { });
1616

1717
Assert.True(filter.IsElementIncludedInReport("Test"), "Element is expected to be included.");
18+
Assert.True(filter.IsElementIncludedInReport("test"), "Element is expected to be included.");
1819
Assert.False(filter.HasCustomFilters);
1920
}
2021

@@ -24,6 +25,7 @@ public void OnlyIncludes_MatchingElement_ElementIsAccepted()
2425
IFilter filter = new DefaultFilter(new[] { "+Test" });
2526

2627
Assert.True(filter.IsElementIncludedInReport("Test"), "Element is expected to be included.");
28+
Assert.True(filter.IsElementIncludedInReport("test"), "Element is expected to be included.");
2729
Assert.True(filter.HasCustomFilters);
2830
}
2931

@@ -33,6 +35,7 @@ public void OnlyIncludes_NotMatchingElement_ElementIsNotAccepted()
3335
IFilter filter = new DefaultFilter(new[] { "+Test" });
3436

3537
Assert.False(filter.IsElementIncludedInReport("Test123"), "Element is expected to be excluded.");
38+
Assert.False(filter.IsElementIncludedInReport("test123"), "Element is expected to be excluded.");
3639
Assert.True(filter.HasCustomFilters);
3740
}
3841

@@ -42,7 +45,9 @@ public void OnlyIncludesWithWildcards_MatchingElement_ElementIsAccepted()
4245
IFilter filter = new DefaultFilter(new[] { "+Test*" });
4346

4447
Assert.True(filter.IsElementIncludedInReport("Test"), "Element is expected to be included.");
48+
Assert.True(filter.IsElementIncludedInReport("test"), "Element is expected to be included.");
4549
Assert.True(filter.IsElementIncludedInReport("Test123"), "Element is expected to be included.");
50+
Assert.True(filter.IsElementIncludedInReport("test123"), "Element is expected to be included.");
4651
Assert.True(filter.HasCustomFilters);
4752
}
4853

@@ -52,7 +57,9 @@ public void OnlyIncludesWithWildcards_NotMatchingElement_ElementIsNotAccepted()
5257
IFilter filter = new DefaultFilter(new[] { "+Test*" });
5358

5459
Assert.False(filter.IsElementIncludedInReport("PrefixTest"), "Element is expected to be included.");
60+
Assert.False(filter.IsElementIncludedInReport("prefixtest"), "Element is expected to be included.");
5561
Assert.False(filter.IsElementIncludedInReport("PrefixTest123"), "Element is expected to be included.");
62+
Assert.False(filter.IsElementIncludedInReport("prefixtest123"), "Element is expected to be included.");
5663
Assert.True(filter.HasCustomFilters);
5764
}
5865

@@ -62,6 +69,7 @@ public void IncludesAndExcludes_MatchingElement_ElementIsAccepted()
6269
IFilter filter = new DefaultFilter(new[] { "+Test", "-SomeExclude" });
6370

6471
Assert.True(filter.IsElementIncludedInReport("Test"), "Element is expected to be included.");
72+
Assert.True(filter.IsElementIncludedInReport("test"), "Element is expected to be included.");
6573
Assert.True(filter.HasCustomFilters);
6674
}
6775

@@ -71,6 +79,7 @@ public void IncludesAndExcludes_NotMatchingElement_ElementIsNotAccepted()
7179
IFilter filter = new DefaultFilter(new[] { "+Test", "-Test" });
7280

7381
Assert.False(filter.IsElementIncludedInReport("Test"), "Element is expected to be excluded.");
82+
Assert.False(filter.IsElementIncludedInReport("test"), "Element is expected to be excluded.");
7483
Assert.True(filter.HasCustomFilters);
7584
}
7685

@@ -80,7 +89,9 @@ public void IncludesAndExcludesWithWildcards_MatchingElement_ElementIsAccepted()
8089
IFilter filter = new DefaultFilter(new[] { "+Test*", "-SomeExclude*" });
8190

8291
Assert.True(filter.IsElementIncludedInReport("Test"), "Element is expected to be included.");
92+
Assert.True(filter.IsElementIncludedInReport("test"), "Element is expected to be included.");
8393
Assert.True(filter.IsElementIncludedInReport("Test123"), "Element is expected to be included.");
94+
Assert.True(filter.IsElementIncludedInReport("test123"), "Element is expected to be included.");
8495
Assert.True(filter.HasCustomFilters);
8596
}
8697

@@ -90,7 +101,9 @@ public void IncludesAndExcludesWithWildcards_NotMatchingElement_ElementIsNotAcce
90101
IFilter filter = new DefaultFilter(new[] { "+Test*", "-Tes*" });
91102

92103
Assert.False(filter.IsElementIncludedInReport("Test"), "Element is expected to be included.");
104+
Assert.False(filter.IsElementIncludedInReport("test"), "Element is expected to be included.");
93105
Assert.False(filter.IsElementIncludedInReport("PrefixTest123"), "Element is expected to be included.");
106+
Assert.False(filter.IsElementIncludedInReport("prefixtest123"), "Element is expected to be included.");
94107
Assert.True(filter.HasCustomFilters);
95108
}
96109
}

‎src/ReportGenerator.Core.Test/ReportGenerator.Core.Test.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<TargetFramework>netcoreapp3.1</TargetFramework>
55
<IsPackable>false</IsPackable>
66
<RootNamespace>Palmmedia.ReportGenerator.Core.Test</RootNamespace>
7-
<AssemblyVersion>4.7.0.0</AssemblyVersion>
8-
<FileVersion>4.7.0.0</FileVersion>
7+
<AssemblyVersion>4.7.1.0</AssemblyVersion>
8+
<FileVersion>4.7.1.0</FileVersion>
99
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
1010
</PropertyGroup>
1111

‎src/ReportGenerator.Core/Parser/Filtering/DefaultFilter.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ private static Regex CreateFilterRegex(string filter)
9595
filter = Regex.Escape(filter);
9696
filter = filter.Replace(@"\$\$\$\*", ".*");
9797

98-
return new Regex($"^{filter}$", RegexOptions.Compiled);
98+
return new Regex($"^{filter}$", RegexOptions.Compiled | RegexOptions.IgnoreCase);
9999
}
100100
}
101101
}

‎src/ReportGenerator.Core/ReportGenerator.Core.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
88
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
99
<AssemblyName>ReportGenerator.Core</AssemblyName>
10-
<AssemblyVersion>4.7.0.0</AssemblyVersion>
11-
<FileVersion>4.7.0.0</FileVersion>
10+
<AssemblyVersion>4.7.1.0</AssemblyVersion>
11+
<FileVersion>4.7.1.0</FileVersion>
1212
</PropertyGroup>
1313

1414
<PropertyGroup>

‎src/ReportGenerator.DotnetCorePluginLoader/ReportGenerator.DotnetCorePluginLoader.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<PropertyGroup>
33
<TargetFramework>netcoreapp2.0</TargetFramework>
44
<RootNamespace>ReportGenerator.DotnetCorePluginLoader</RootNamespace>
5-
<AssemblyVersion>4.7.0.0</AssemblyVersion>
6-
<FileVersion>4.7.0.0</FileVersion>
5+
<AssemblyVersion>4.7.1.0</AssemblyVersion>
6+
<FileVersion>4.7.1.0</FileVersion>
77
</PropertyGroup>
88

99
<ItemGroup>

‎src/ReportGenerator.DotnetGlobalTool/ReportGenerator.DotnetGlobalTool.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<AssemblyName>ReportGenerator</AssemblyName>
88
<RootNamespace>Palmmedia.ReportGenerator</RootNamespace>
99
<StartupObject>Palmmedia.ReportGenerator.DotnetGlobalTool.Program</StartupObject>
10-
<AssemblyVersion>4.7.0.0</AssemblyVersion>
11-
<FileVersion>4.7.0.0</FileVersion>
10+
<AssemblyVersion>4.7.1.0</AssemblyVersion>
11+
<FileVersion>4.7.1.0</FileVersion>
1212
</PropertyGroup>
1313

1414
<ItemGroup>

‎src/ReportGenerator.MSBuild/ReportGenerator.MSBuild.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<RootNamespace>Palmmedia.ReportGenerator.MSBuild</RootNamespace>
66
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
77
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
8-
<AssemblyVersion>4.7.0.0</AssemblyVersion>
9-
<FileVersion>4.7.0.0</FileVersion>
8+
<AssemblyVersion>4.7.1.0</AssemblyVersion>
9+
<FileVersion>4.7.1.0</FileVersion>
1010
</PropertyGroup>
1111

1212
<ItemGroup>

‎src/build.proj

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
<!-- Version, adjust before build -->
2424
<PropertyGroup>
25-
<Version>4.7.0</Version>
25+
<Version>4.7.1</Version>
2626
</PropertyGroup>
2727

2828
<!-- Tools -->

0 commit comments

Comments
 (0)