Merge pull request pandas-dev#317 from manahl/remove_powerof2sizes

Remove deprecated usePowerOf2Sizes

Author: jamesblackburn

arctic/_util.py

@@ -39,15 +39,3 @@ def enable_sharding(arctic, library_name, hashed=True):
     else:
         logger.info("Hash sharding 'symbol' on: " + dbname + '.' + library_name)
         c.admin.command('shardCollection', dbname + '.' + library_name, key={'symbol': 'hashed'})
-
-
-def enable_powerof2sizes(arctic, library_name):
-    lib = arctic[library_name]._arctic_lib
-    collection = lib.get_top_level_collection()
-    lib._db.command({"collMod": collection.name, 'usePowerOf2Sizes': "true"})
-    logger.info("usePowerOf2Sizes enabled for %s", collection.name)
-
-    for coll in collection.database.collection_names():
-        if coll.startswith("%s." % collection.name):
-            lib._db.command({"collMod": coll, 'usePowerOf2Sizes': "true"})
-            logger.info("usePowerOf2Sizes enabled for %s", coll)

arctic/store/version_store.py

@@ -6,8 +6,7 @@
 import pymongo
 from pymongo.errors import OperationFailure, AutoReconnect
 
-from .._util import indent, enable_powerof2sizes, \
-    enable_sharding
+from .._util import indent, enable_sharding
 from ..date import mktz, datetime_to_ms, ms_to_datetime
 from ..decorators import mongo_retry
 from ..exceptions import NoDataFoundException, DuplicateSnapshotException, \
@@ -51,12 +50,6 @@ def initialize_library(cls, arctic_lib, hashed=True, **kwargs):
         VersionStore._bson_handler.initialize_library(arctic_lib, **kwargs)
         VersionStore(arctic_lib)._ensure_index()
 
-        logger.info("Trying to enable usePowerOf2Sizes...")
-        try:
-            enable_powerof2sizes(arctic_lib.arctic, arctic_lib.get_name())
-        except OperationFailure as e:
-            logger.error("Library created, but couldn't enable usePowerOf2Sizes: %s" % str(e))
-
         logger.info("Trying to enable sharding...")
         try:
             enable_sharding(arctic_lib.arctic, arctic_lib.get_name(), hashed=hashed)

tests/unit/store/test_version_store.py

@@ -146,12 +146,10 @@ def test_write_check_quota():
 def test_initialize_library():
     arctic_lib = create_autospec(ArcticLibraryBinding)
     arctic_lib.arctic = create_autospec(Arctic, _allow_secondary=False)
-    with patch('arctic.store.version_store.enable_powerof2sizes', autospec=True) as enable_powerof2sizes, \
-         patch('arctic.store.version_store.enable_sharding', autospec=True) as enable_sharding:
+    with patch('arctic.store.version_store.enable_sharding', autospec=True) as enable_sharding:
         arctic_lib.get_top_level_collection.return_value.database.create_collection.__name__ = 'some_name'
         arctic_lib.get_top_level_collection.return_value.database.collection_names.__name__ = 'some_name'
         VersionStore.initialize_library(arctic_lib, hashed=sentinel.hashed)
-    assert enable_powerof2sizes.call_args_list == [call(arctic_lib.arctic, arctic_lib.get_name())]
     assert enable_sharding.call_args_list == [call(arctic_lib.arctic, arctic_lib.get_name(), hashed=sentinel.hashed)]