Merge pull request pandas-dev#31 from manahl/arctic_exception_hook

MDP-341 ensure the external error hook is called when an exception occurs

Author: jamesblackburn

arctic/decorators.py

@@ -7,7 +7,7 @@
 
 from pymongo.errors import AutoReconnect, OperationFailure, DuplicateKeyError, ServerSelectionTimeoutError
 
-from .hooks import _log_exception_hook as _log_exception
+from .hooks import log_exception as _log_exception
 
 logger = logging.getLogger(__name__)
 

tests/unit/test_decorators_unit.py

@@ -6,6 +6,7 @@
 from arctic import decorators
 from arctic.decorators import mongo_retry, _get_host
 from pymongo.collection import Collection
+from arctic.hooks import register_log_exception_hook
 
 
 def test_mongo_retry():
@@ -35,6 +36,29 @@ def foo(self):
     assert he.call_args_list[1][0][2] == 2
 
 
+def test_mongo_retry_hook_changes():
+    retries = [2]
+    self = MagicMock()
+    hook1 = Mock()
+    register_log_exception_hook(hook1)
+    hook2 = Mock()
+
+    @mongo_retry
+    def foo(self):
+        if retries[0] == 2:
+            retries[0] -= 1
+            raise OperationFailure('error')
+        elif retries[0] == 1:
+            register_log_exception_hook(hook2)
+            retries[0] -= 1
+            raise AutoReconnect('error')
+        return "success"
+    foo(self)
+
+    assert hook1.call_count == 1
+    assert hook2.call_count == 1
+
+
 def test_mongo_retry_fails():
     error = OperationFailure('error')
     retries = [16]