Unit test improvements in Chunkstore

Author: bmoscon

CHANGES.md

@@ -10,6 +10,7 @@
   * Bugfix: #169 Dtype mismatch in chunkstore updates
   * Feature: #171 allow deleting of values within a date range in ChunkStore
   * Bugfix: #172 Fix date range bug when querying dates in the middle of chunks
+  * Bugfix: #176 Fix overwrite failures in Chunkstore
 
 ### 1.25 (2016-05-23)
 

arctic/chunkstore/chunkstore.py

@@ -133,7 +133,7 @@ def read(self, symbol, chunk_range=None, filter_data=True):
 
         sym = self._get_symbol_info(symbol)
         if not sym:
-            raise NoDataFoundException('No data found for %s in library %s' % (symbol, self._collection.get_name()))
+            raise NoDataFoundException('No data found for %s' % (symbol))
 
         spec = {'symbol': symbol,
                 }

tests/integration/chunkstore/test_chunkstore.py

@@ -2,6 +2,7 @@
 from datetime import datetime as dt
 from pandas.util.testing import assert_frame_equal, assert_series_equal
 from arctic.date import DateRange
+from arctic.exceptions import NoDataFoundException
 import pandas as pd
 import numpy as np
 import random
@@ -731,3 +732,41 @@ def test_read_chunk_range(chunkstore_lib):
 
     df2 = chunkstore_lib.read('test', chunk_range=DateRange(None, None))
     assert_frame_equal(df, df2)
+
+
+def test_read_data_doesnt_exist(chunkstore_lib):
+    with pytest.raises(NoDataFoundException) as e:
+        chunkstore_lib.read('some_data')
+    assert('No data found' in str(e))
+
+
+def test_invalid_type(chunkstore_lib):
+    with pytest.raises(Exception) as e:
+        chunkstore_lib.write('some_data', str("Cannot write a string"), 'D')
+    assert('Can only chunk Series and DataFrames' in str(e))
+
+
+def test_append_no_data(chunkstore_lib):
+    with pytest.raises(NoDataFoundException) as e:
+        chunkstore_lib.append('some_data', "")
+    assert('Symbol does not exist.' in str(e))
+
+
+def test_append_no_new_data(chunkstore_lib):
+    df = DataFrame(data={'data': [1, 2, 3, 4, 5, 6, 7, 8, 9]},
+                   index=MultiIndex.from_tuples([(dt(2016, 1, 1), 1),
+                                                 (dt(2016, 1, 2), 1),
+                                                 (dt(2016, 1, 3), 1),
+                                                 (dt(2016, 2, 1), 1),
+                                                 (dt(2016, 2, 2), 1),
+                                                 (dt(2016, 2, 3), 1),
+                                                 (dt(2016, 3, 1), 1),
+                                                 (dt(2016, 3, 2), 1),
+                                                 (dt(2016, 3, 3), 1)],
+                                                names=['date', 'id'])
+                   )
+
+    chunkstore_lib.write('test', df, 'D')
+    chunkstore_lib.append('test', df)
+    r = chunkstore_lib.read('test')
+    assert_frame_equal(df, r)