fixed: #314

Author: maximv

src/DryIoc/Container.cs

@@ -4147,7 +4147,6 @@ public static T New<T>(this IContainer container, Made.TypedMade<T> made,
         /// <param name="container">Container</param> <param name="serviceType">New service type.</param>
         /// <param name="registeredServiceType">Existing registered service type.</param>
         /// <param name="serviceKey">(optional)</param> <param name="registeredServiceKey">(optional)</param>
-        /// <remarks>Does nothing if registration is already exists.</remarks>
         public static void RegisterMapping(this IContainer container, Type serviceType, Type registeredServiceType,
             object serviceKey = null, object registeredServiceKey = null) =>
             Registrator.RegisterMapping(container,
@@ -4160,7 +4159,6 @@ public static void RegisterMapping(this IContainer container, Type serviceType,
         /// <typeparam name="TService">New service type.</typeparam>
         /// <typeparam name="TRegisteredService">Existing registered service type.</typeparam>
         /// <param name="serviceKey">(optional)</param> <param name="registeredServiceKey">(optional)</param>
-        /// <remarks>Does nothing if registration is already exists.</remarks>
         public static void RegisterMapping<TService, TRegisteredService>(this IContainer container,
             object serviceKey = null, object registeredServiceKey = null) =>
             Registrator.RegisterMapping(container,
@@ -7584,11 +7582,11 @@ public static void Unregister<TService>(this IRegistrator registrator,
         /// Throw if no such registered service type in container.</summary>
         /// <param name="registrator">Registrator</param> <param name="serviceType">New service type.</param>
         /// <param name="registeredServiceType">Existing registered service type.</param>
+        /// <param name="ifAlreadyRegistered">The registration to overwrite or preserve the already registered service</param>
         /// <param name="serviceKey">(optional)</param> <param name="registeredServiceKey">(optional)</param>
         /// <param name="factoryType">(optional) By default is <see cref="FactoryType.Service"/></param>
-        /// <remarks>Does nothing if registration is already exists.</remarks>
         public static void RegisterMapping(this IRegistrator registrator, Type serviceType, Type registeredServiceType,
-            object serviceKey = null, object registeredServiceKey = null, FactoryType factoryType = FactoryType.Service)
+            IfAlreadyRegistered? ifAlreadyRegistered, object serviceKey = null, object registeredServiceKey = null, FactoryType factoryType = FactoryType.Service)
         {
             var factories = registrator.GetRegisteredFactories(registeredServiceType, registeredServiceKey, factoryType);
 
@@ -7598,20 +7596,37 @@ public static void RegisterMapping(this IRegistrator registrator, Type serviceTy
             if (factories.Length > 1)
                 Throw.It(Error.RegisterMappingUnableToSelectFromMultipleFactories, serviceType, serviceKey, factories);
 
-            registrator.Register(factories[0], serviceType, serviceKey, IfAlreadyRegistered.Keep, false);
+            registrator.Register(factories[0], serviceType, serviceKey, ifAlreadyRegistered, false);
         }
 
+        /// <summary>Registers new service type with factory for registered service type.
+        /// Throw if no such registered service type in container.</summary>
+        public static void RegisterMapping(this IRegistrator registrator, Type serviceType, Type registeredServiceType,
+            object serviceKey = null, object registeredServiceKey = null, FactoryType factoryType = FactoryType.Service) =>
+            registrator.RegisterMapping(serviceType, registeredServiceType, null, serviceKey, registeredServiceKey, factoryType);
+
         /// <summary>Registers new service type with factory for registered service type.
         /// Throw if no such registered service type in container.</summary>
         /// <param name="registrator">Registrator</param>
         /// <typeparam name="TService">New service type.</typeparam>
         /// <typeparam name="TRegisteredService">Existing registered service type.</typeparam>
         /// <param name="serviceKey">(optional)</param> <param name="registeredServiceKey">(optional)</param>
         /// <param name="factoryType">(optional) By default is <see cref="FactoryType.Service"/></param>
-        /// <remarks>Does nothing if registration is already exists.</remarks>
         public static void RegisterMapping<TService, TRegisteredService>(this IRegistrator registrator,
             object serviceKey = null, object registeredServiceKey = null, FactoryType factoryType = FactoryType.Service) =>
-            registrator.RegisterMapping(typeof(TService), typeof(TRegisteredService), serviceKey, registeredServiceKey);
+            registrator.RegisterMapping(typeof(TService), typeof(TRegisteredService), null, serviceKey, registeredServiceKey);
+
+        /// <summary>Registers new service type with factory for registered service type.
+        /// Throw if no such registered service type in container.</summary>
+        /// <param name="container">Container</param>
+        /// <typeparam name="TService">New service type.</typeparam>
+        /// <typeparam name="TRegisteredService">Existing registered service type.</typeparam>
+        /// <param name="ifAlreadyRegistered">The registration to overwrite or preserve the already registered service</param>
+        /// <param name="serviceKey">(optional)</param> <param name="registeredServiceKey">(optional)</param>
+        public static void RegisterMapping<TService, TRegisteredService>(this IContainer container,
+            IfAlreadyRegistered ifAlreadyRegistered, object serviceKey = null, object registeredServiceKey = null) =>
+            Registrator.RegisterMapping(container,
+                typeof(TService), typeof(TRegisteredService), ifAlreadyRegistered, serviceKey, registeredServiceKey);
 
         /// <summary>Register a service without implementation which can be provided later in terms
         /// of normal registration with IfAlreadyRegistered.Replace parameter.

test/DryIoc.IssuesTests/GHIssue314_Expose_the_usual_IfAlreadyRegistered_option_parameter_for_RegisterMapping.cs

@@ -0,0 +1,28 @@
+using System.Linq;
+using NUnit.Framework;
+
+namespace DryIoc.IssuesTests
+{
+    [TestFixture]
+    public class GHIssue314_Expose_the_usual_IfAlreadyRegistered_option_parameter_for_RegisterMapping
+    {
+        [Test]
+        public void Test()
+        {
+            var container = new Container();
+
+            container.Register<LeafOne>(Reuse.Singleton);
+            container.Register<LeafTwo>(Reuse.Singleton);
+
+            container.RegisterMapping<Base, LeafOne>();
+            container.RegisterMapping<Base, LeafTwo>();
+
+            var bases = container.ResolveMany<Base>().ToArray();
+            Assert.AreEqual(2, bases.Length);
+        }
+
+        class Base { };
+        class LeafOne : Base { };
+        class LeafTwo : Base { };
+    }
+}