fixup! feat: Add user configuration for all providers

Fix typo in lockPassword logic, and add unit test

Author: dlipovetsky

go.mod

@@ -15,6 +15,7 @@ require (
 	github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/api v0.0.0-00010101000000-000000000000
 	github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/common v0.0.0-00010101000000-000000000000
 	github.com/go-logr/logr v1.4.1
+	github.com/google/go-cmp v0.6.0
 	github.com/onsi/ginkgo/v2 v2.16.0
 	github.com/onsi/gomega v1.31.1
 	github.com/spf13/pflag v1.0.5
@@ -71,7 +72,6 @@ require (
 	github.com/golang/protobuf v1.5.4 // indirect
 	github.com/google/cel-go v0.17.7 // indirect
 	github.com/google/gnostic-models v0.6.8 // indirect
-	github.com/google/go-cmp v0.6.0 // indirect
 	github.com/google/go-github/v53 v53.2.0 // indirect
 	github.com/google/go-querystring v1.1.0 // indirect
 	github.com/google/gofuzz v1.2.0 // indirect

pkg/handlers/generic/mutation/users/inject.go

@@ -119,7 +119,6 @@ func (h *usersPatchHandler) Mutate(
 func generateBootstrapUser(userFromVariable v1alpha1.User) bootstrapv1.User {
 	bootstrapUser := bootstrapv1.User{
 		Name:              userFromVariable.Name,
-		Passwd:            ptr.To(userFromVariable.HashedPassword),
 		SSHAuthorizedKeys: userFromVariable.SSHAuthorizedKeys,
 		Sudo:              userFromVariable.Sudo,
 	}
@@ -133,9 +132,12 @@ func generateBootstrapUser(userFromVariable v1alpha1.User) bootstrapv1.User {
 	//
 	// We disable password authentication by default.
 	bootstrapUser.LockPassword = ptr.To(true)
+
 	if userFromVariable.HashedPassword != "" {
 		// We enable password authentication only if a hashed password is defined.
-		bootstrapUser.LockPassword = ptr.To(true)
+		bootstrapUser.LockPassword = ptr.To(false)
+
+		bootstrapUser.Passwd = ptr.To(userFromVariable.HashedPassword)
 	}
 
 	return bootstrapUser

pkg/handlers/generic/mutation/users/inject_test.go

@@ -0,0 +1,61 @@
+// Copyright 2023 D2iQ, Inc. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+package users
+
+import (
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+	"k8s.io/utils/ptr"
+	bootstrapv1 "sigs.k8s.io/cluster-api/bootstrap/kubeadm/api/v1beta1"
+
+	"github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/api/v1alpha1"
+)
+
+func Test_generateBootstrapUser(t *testing.T) {
+	type args struct {
+		userFromVariable v1alpha1.User
+	}
+	tests := []struct {
+		name string
+		args args
+		want bootstrapv1.User
+	}{
+		{
+			name: "if user sets hashed password, enable password auth and set passwd",
+			args: args{
+				userFromVariable: v1alpha1.User{
+					Name:           "example",
+					HashedPassword: "example",
+				},
+			},
+			want: bootstrapv1.User{
+				Name:         "example",
+				Passwd:       ptr.To("example"),
+				LockPassword: ptr.To(false),
+			},
+		},
+		{
+			name: "if user does not set hashed password, disable password auth and do not set passwd",
+			args: args{
+				userFromVariable: v1alpha1.User{
+					Name: "example",
+				},
+			},
+			want: bootstrapv1.User{
+				Name:         "example",
+				Passwd:       nil,
+				LockPassword: ptr.To(true),
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := generateBootstrapUser(tt.args.userFromVariable)
+			if diff := cmp.Diff(tt.want, got); diff != "" {
+				t.Errorf("generateBootstrapUser() mismatch (-want +got):\n%s", diff)
+			}
+		})
+	}
+}