lint fixes

Author: deepakm-ntnx

pkg/handlers/nutanix/mutation/machinedetails/inject_control_plane.go

@@ -139,13 +139,13 @@ func (h *nutanixMachineDetailsControlPlanePatchHandler) Mutate(
 				subnet := capxv1.NutanixResourceIdentifier{}
 				if subnetCRE.Type == v1alpha1.NutanixIdentifierName {
 					subnet.Type = capxv1.NutanixIdentifierName
-					if subnetCRE.Name == nil || len(*subnetCRE.Name) == 0{
+					if subnetCRE.Name == nil || *subnetCRE.Name == "" {
 						continue
 					}
 					subnet.Name = subnetCRE.Name
 				} else {
 					subnet.Type = capxv1.NutanixIdentifierUUID
-					if subnetCRE.UUID == nil || len(*subnetCRE.UUID) == 0{
+					if subnetCRE.UUID == nil || *subnetCRE.UUID == "" {
 						continue
 					}
 					subnet.UUID = subnetCRE.UUID

pkg/handlers/nutanix/mutation/machinedetails/inject_worker.go

@@ -128,13 +128,13 @@ func (h *nutanixMachineDetailsWorkerPatchHandler) Mutate(
 				subnet := capxv1.NutanixResourceIdentifier{}
 				if subnetCRE.Type == v1alpha1.NutanixIdentifierName {
 					subnet.Type = capxv1.NutanixIdentifierName
-					if subnetCRE.Name == nil || len(*subnetCRE.Name) == 0 {
+					if subnetCRE.Name == nil || *subnetCRE.Name == "" {
 						continue
 					}
 					subnet.Name = subnetCRE.Name
 				} else {
 					subnet.Type = capxv1.NutanixIdentifierUUID
-					if subnetCRE.UUID == nil || len(*subnetCRE.UUID) == 0 {
+					if subnetCRE.UUID == nil || *subnetCRE.UUID == "" {
 						continue
 					}
 					subnet.UUID = subnetCRE.UUID

pkg/handlers/nutanix/mutation/machinedetails/variables_test.go

@@ -15,6 +15,9 @@ import (
 )
 
 func TestVariableValidation(t *testing.T) {
+	testImageName := "fake-image"
+	testPEClusterName := "fake-pe-cluster"
+	testProject := "fake-project"
 	capitest.ValidateDiscoverVariables(
 		t,
 		clusterconfig.MetaVariableName,
@@ -30,13 +33,22 @@ func TestVariableValidation(t *testing.T) {
 							BootType:       "legacy",
 							VCPUSockets:    2,
 							VCPUsPerSocket: 1,
-							Image:          v1alpha1.NutanixResourceIdentifier{},
-							Cluster:        v1alpha1.NutanixResourceIdentifier{},
+							Image: v1alpha1.NutanixResourceIdentifier{
+								Type: v1alpha1.NutanixIdentifierName,
+								Name: &testImageName,
+							},
+							Cluster: v1alpha1.NutanixResourceIdentifier{
+								Type: v1alpha1.NutanixIdentifierName,
+								Name: &testPEClusterName,
+							},
 							MemorySize:     "8Gi",
 							SystemDiskSize: "40Gi",
 							Subnets:        []v1alpha1.NutanixResourceIdentifier{},
-							Project:        v1alpha1.NutanixResourceIdentifier{},
-							GPUs:           []v1alpha1.NutanixGPU{},
+							Project: v1alpha1.NutanixResourceIdentifier{
+								Type: v1alpha1.NutanixIdentifierName,
+								Name: &testProject,
+							},
+							GPUs: []v1alpha1.NutanixGPU{},
 						},
 					},
 				},

pkg/handlers/nutanix/mutation/metapatch_handler_test.go

@@ -26,7 +26,6 @@ import (
 	nutanixclusterconfig "github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pkg/handlers/nutanix/clusterconfig"
 	"github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pkg/handlers/nutanix/mutation/controlplaneendpoint"
 	controlplaneendpointtests "github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pkg/handlers/nutanix/mutation/controlplaneendpoint/tests"
-	"github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pkg/handlers/nutanix/mutation/machinedetails"
 	"github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pkg/handlers/nutanix/mutation/prismcentralendpoint"
 	prismcentralendpointtests "github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pkg/handlers/nutanix/mutation/prismcentralendpoint/tests"
 )
@@ -64,7 +63,6 @@ func TestGeneratePatches(t *testing.T) {
 		prismcentralendpoint.VariableName,
 	)
 
-
 	auditpolicytests.TestGeneratePatches(
 		t,
 		metaPatchGeneratorFunc(mgr),