changes for review

Author: d-a-v

libraries/DNSServer/examples/CaptivePortalAdvanced/CaptivePortalAdvanced.ino

@@ -5,17 +5,6 @@
 #include <ESP8266mDNS.h>
 #include <EEPROM.h>
 
-boolean isIp(String str);
-String toStringIp(IPAddress ip);
-void loadCredentials();
-void saveCredentials();
-void handleRoot();
-boolean captivePortal();
-void handleWifi();
-void handleWifiSave();
-void handleNotFound();
-
-
 /*
    This example serves a "hello world" on a WLAN and a SoftAP at the same time.
    The SoftAP allow you to configure WLAN parameters at run time. They are not setup in the sketch but saved on EEPROM.

libraries/ESP8266WebServer/examples/AdvancedWebServer/AdvancedWebServer.ino

@@ -40,8 +40,6 @@ ESP8266WebServer server(80);
 
 const int led = 13;
 
-void drawGraph();
-
 void handleRoot() {
   digitalWrite(led, 1);
   char temp[400];

tests/host/Makefile

@@ -217,12 +217,12 @@ ARDUINO_LIBS := \
 	) \
 
 MOCK_ARDUINO_LIBS := \
-	common/MockClientContextSocket.cpp \
-	common/MockClientContext.cpp \
+	common/ClientContextSocket.cpp \
+	common/ClientContextTools.cpp \
 	common/MockWiFiServerSocket.cpp \
 	common/MockWiFiServer.cpp \
-	common/MockUDPSocket.cpp \
-	common/ArduinoWire.cpp \
+	common/UdpContextSocket.cpp \
+	common/MockWire.cpp \
 	common/MockEsp.cpp \
 	common/MockEEPROM.cpp \
 	common/MockSPI.cpp \

tests/host/README.txt

@@ -34,7 +34,9 @@ run it:
 	./bin/Blink -h
 
 
-Optional 'D=1' enables core debug.
+Optional 'D=1' enables core debug (same as IDE's tools menu)
+Optional 'OPTZ=-O2' will update gcc -O option (default is -Os, D=1 implies -O0)
+Optional 'FORCE32=0' will use native/default gcc (default is FORCE32=1 unless gcc-multilib is not detected)
 
 
 Non exhaustive list of working examples:
@@ -51,15 +53,16 @@ Compile other sketches:
 - CAVEAT: functions must be declared *before* being called (arduino builder is not around)
 
 	make D=1  ULIBDIRS=/path/to/your/arduino/libraries/lib1:/path/to/another/place/lib2  /path/to/your/sketchdir/sketch/sketch
-  or
+  or:
 	ULIBDIRS=/path/to/your/arduino/libraries/lib1:/path/to/another/place/lib2  make  D=1  /path/to/your/sketchdir/sketch/sketch
-  or
-	export ULIBDIRS=/path/to/your/arduino/libraries/lib1:/path/to/another/place/lib2
-	make  D=1  /path/to/your/sketchdir/sketch/sketch
-
 
-Build all examples with debug enabled (D=1): (not fully working yet)
-	make D=1 examples
+  or (preferred):
+	export ULIBDIRS=/path/to/your/arduino/libraries/lib1:/path/to/another/place/lib2
+	export D=1
+	export OPTZ=-O2
+	make clean
+	make /path/to/your/sketchdir/sketch/sketch
+	./bin/sketch/sketch
 
 
 Running a sketch
@@ -85,10 +88,11 @@ Make fun, propose PRs.
 
 - spiffs in a file (done, need to initialize and check)
 - EEPROM in a file (partly done)
-- SDCARD on Host filesystem ?
+- SDCARD on Host filesystem ? or in an image ?
 - nice curses interface to display/change gpios ?
 - display device emulation (like ssd1306)
 - optionaly use arduino-builder ?
-- store sketch objects and binaries outside from the source directories
+- store sketch objects and binaries outside from the source directories (done for sketches)
 - compile and use lwIP on host
-#1715
+- easily debug HTTP classes
+- https://github.com/esp8266/Arduino/issues/1715

tests/host/common/ArduinoMain.cpp

@@ -133,7 +133,7 @@ int main (int argc, char* const argv [])
 			p.events = POLLIN;
 			if (poll(&p, 1, 0) && p.revents == POLLIN)
 			{
-				fprintf(stderr, MOCK "UDP poll(%d) -> cb\n", (int)p.fd);
+				fprintf(stderr, MOCK "UDP poll(%d) -> cb\r", (int)p.fd);
 				udp.second->mock_cb();
 			}
 		}

tests/host/common/MockClientContextSocket.cpp renamed to tests/host/common/ClientContextSocket.cpp

@@ -39,8 +39,10 @@
 
 extern "C" const ip_addr_t ip_addr_any = IPADDR4_INIT(IPADDR_ANY);
 
-#define int2pcb(x) ((tcp_pcb*)(long)(x))
-#define pcb2int(x) ((int)(long)(x))
+#define int2pcb(x) ((tcp_pcb*)(intptr_t)(x))
+#define pcb2int(x) ((int)(intptr_t)(x))
+
+// lwIP API side of WiFiServer
 
 WiFiServer::WiFiServer (IPAddress addr, uint16_t port)
 {

tests/host/common/MockClientContext.cpp renamed to tests/host/common/ClientContextTools.cpp

@@ -37,8 +37,10 @@
 #include <poll.h>
 #include <unistd.h>
 
-#define int2pcb(x) ((tcp_pcb*)(long)(x))
-#define pcb2int(x) ((int)(long)(x))
+#define int2pcb(x) ((tcp_pcb*)(intptr_t)(x))
+#define pcb2int(x) ((int)(intptr_t)(x))
+
+// host socket internal side of WiFiServer
 
 int serverAccept (int srvsock)
 {