Skip to content

fix: add recursive=true to mkdirSync when creating output folder #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2021
Merged

fix: add recursive=true to mkdirSync when creating output folder #381

merged 1 commit into from
Jan 12, 2021

Conversation

kachkaev
Copy link
Contributor

After configuring nyc with

    "report-dir": "cypress/test-results/coverage",
    "reporter": "json",
    "temp-dir": "cypress/test-results/coverage/.nyc_output"

I observed the following error when starting the tests in a fresh repo clone:

ENOENT: no such file or directory, mkdir '/path/to/project/cypress/test-results/coverage/.nyc_output'.

This PR fixes this by recursively creating all subfolders that are needed to satisfy the config.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bahmutov
bahmutov approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh, good catch, I missed it

@bahmutov bahmutov changed the title Add { recursive: true } to mkdirSync fix: add recursive=true to mkdirSync when creating output folder Jan 12, 2021
@bahmutov bahmutov merged commit 3c28086 into cypress-io:master Jan 12, 2021
@bahmutov
Copy link
Contributor

🎉 This PR is included in version 3.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kachkaev kachkaev deleted the patch-1 branch January 12, 2021 18:49
@kachkaev
Copy link
Contributor Author

Wow, terrific response time! Big thanks for merging and releasing a patch so quickly! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kachkaev @CLAassistant @bahmutov