Skip to content

fix: Handle backslashes in coverage file path #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2020
Merged

fix: Handle backslashes in coverage file path #356

merged 2 commits into from
Dec 10, 2020

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Dec 10, 2020

issue: #254

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bahmutov
bahmutov approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, let's land and hope it resolves Windows problems

@bahmutov bahmutov merged commit c41e77a into cypress-io:master Dec 10, 2020
@bahmutov
Copy link
Contributor

🎉 This PR is included in version 3.8.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taki9
Copy link
Contributor Author

taki9 commented Dec 14, 2020

nice, let's land and hope it resolves Windows problems

It resolved for us. I think it was only an effect treatment, but the real issue is this: #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taki9 @CLAassistant @bahmutov