Skip to content

nyc does not load get-module-type #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bahmutov opened this issue Oct 16, 2020 · 1 comment · Fixed by #322
Closed

nyc does not load get-module-type #321

bahmutov opened this issue Oct 16, 2020 · 1 comment · Fixed by #322
Assignees
@bahmutov
Labels
bug Something isn't working released

Comments

@bahmutov
Copy link
Contributor

When using cypress-react-unit-test noticed a blocking error:

nyc could not require get-module-type dependency.

Trying to disable the code coverage using env: coverage: false did not solve the problem, because nyc require is eager

// cypress-react-unit-test/plugins/load-webpack/index.js
require('@cypress/code-coverage/task')(on, config)

project https://github.com/bahmutov/react-testing-rails-webpacker

It would be nice if nyc require was only done when it was needed for reporting
@bahmutov bahmutov self-assigned this Oct 16, 2020
@bahmutov bahmutov added the bug Something isn't working label Oct 16, 2020
@bahmutov bahmutov mentioned this issue Oct 16, 2020
Merged
@bahmutov
Copy link
Contributor Author

🎉 This issue has been resolved in version 3.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahmutov bahmutov

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move nyc require to only when needed cypress-io/code-coverage
1 participant
@bahmutov