cross compile and flags

Author: gaeljw

build.sbt

@@ -8,22 +8,86 @@ val jacksonVersion = "2.11.3"
 val mockitoScalaVersion = "1.16.0"
 val junitVersion = "4.13.1"
 
+scalaVersion := scala213
+
+// Source: https://nathankleyn.com/2019/05/13/recommended-scalac-flags-for-2-13/
+lazy val scalacOptions213 = Seq(
+  "-deprecation", // Emit warning and location for usages of deprecated APIs.
+  "-explaintypes", // Explain type errors in more detail.
+  "-feature", // Emit warning and location for usages of features that should be imported explicitly.
+  "-language:existentials", // Existential types (besides wildcard types) can be written and inferred
+  "-language:experimental.macros", // Allow macro definition (besides implementation and application)
+  "-language:higherKinds", // Allow higher-kinded types
+  "-language:implicitConversions", // Allow definition of implicit functions called views
+  "-unchecked", // Enable additional warnings where generated code depends on assumptions.
+  "-Xcheckinit", // Wrap field accessors to throw an exception on uninitialized access.
+  "-Xfatal-warnings", // Fail the compilation if there are any warnings.
+  "-Xlint:adapted-args", // Warn if an argument list is modified to match the receiver.
+  "-Xlint:constant", // Evaluation of a constant arithmetic expression results in an error.
+  "-Xlint:delayedinit-select", // Selecting member of DelayedInit.
+  "-Xlint:doc-detached", // A Scaladoc comment appears to be detached from its element.
+  "-Xlint:inaccessible", // Warn about inaccessible types in method signatures.
+  "-Xlint:infer-any", // Warn when a type argument is inferred to be `Any`.
+  "-Xlint:missing-interpolator", // A string literal appears to be missing an interpolator id.
+//  "-Xlint:nullary-override", // Warn when non-nullary `def f()' overrides nullary `def f'.
+  "-Xlint:nullary-unit", // Warn when nullary methods return Unit.
+  "-Xlint:option-implicit", // Option.apply used implicit view.
+  "-Xlint:package-object-classes", // Class or object defined in package object.
+  "-Xlint:poly-implicit-overload", // Parameterized overloaded implicit methods are not visible as view bounds.
+  "-Xlint:private-shadow", // A private field (or class parameter) shadows a superclass field.
+  "-Xlint:stars-align", // Pattern sequence wildcard must align with sequence component.
+  "-Xlint:type-parameter-shadow", // A local type parameter shadows a type already in scope.
+  "-Ywarn-dead-code", // Warn when dead code is identified.
+  "-Ywarn-extra-implicit", // Warn when more than one implicit parameter section is defined.
+  "-Ywarn-numeric-widen", // Warn when numerics are widened.
+  "-Ywarn-unused:implicits", // Warn if an implicit parameter is unused.
+  "-Ywarn-unused:imports", // Warn if an import selector is not referenced.
+  "-Ywarn-unused:locals", // Warn if a local definition is unused.
+  "-Ywarn-unused:params", // Warn if a value parameter is unused.
+  "-Ywarn-unused:patvars", // Warn if a variable bound in a pattern is unused.
+  "-Ywarn-unused:privates", // Warn if a private member is unused.
+  "-Ywarn-value-discard", // Warn when non-Unit expression results are unused.
+  "-Ybackend-parallelism", "8", // Enable paralellisation — change to desired number!
+  "-Ycache-plugin-class-loader:last-modified", // Enables caching of classloaders for compiler plugins
+  "-Ycache-macro-class-loader:last-modified", // and macro definitions. This can lead to performance improvements.
+)
+
+val scalacOptions212 = Seq(
+  "-deprecation", // Emit warning and location for usages of deprecated APIs.
+  "-encoding", "utf-8", // Specify character encoding used by source files.
+  "-feature", // Emit warning and location for usages of features that should be imported explicitly.
+  "-language:implicitConversions", // Allow definition of implicit functions called views
+)
+
+val scalacOptions211 = Seq(
+  "-deprecation",
+  "-encoding", "UTF-8", // yes, this is 2 args
+  "-feature",
+  "-language:implicitConversions"
+)
+
 lazy val commonSettings = Seq(
   organization := "io.cucumber",
-  scalaVersion := scala213,
-  libraryDependencies += "com.novocode" % "junit-interface" % "0.11" % Test
+  libraryDependencies += "com.novocode" % "junit-interface" % "0.11" % Test,
+  scalacOptions += "-target:jvm-1.8",
+  scalacOptions ++= {
+    CrossVersion.partialVersion(scalaVersion.value) match {
+      case Some((2, 11)) => scalacOptions211
+      case Some((2, 12)) => scalacOptions212
+      case Some((2, 13)) => scalacOptions213
+      case _ => Seq()
+    }
+  },
 )
 
-lazy val root = project
-  .in(file("."))
+lazy val root = (project in file("."))
   .settings(commonSettings)
   .aggregate(
-    cucumberScala,
-    examples
+    cucumberScala.projectRefs ++
+      examples.projectRefs: _*
   )
 
-lazy val cucumberScala = project
-  .in(file("cucumber-scala"))
+lazy val cucumberScala = (projectMatrix in file("cucumber-scala"))
   .settings(commonSettings)
   .settings(
     name := "cucumber-scala",
@@ -37,11 +101,25 @@ lazy val cucumberScala = project
       "junit" % "junit" % junitVersion % Test,
       "io.cucumber" % "cucumber-junit" % cucumberVersion % Test,
       "org.mockito" %% "mockito-scala" % mockitoScalaVersion % Test
-    )
+    ),
+    libraryDependencies ++= {
+      CrossVersion.partialVersion(scalaVersion.value) match {
+        case Some((2, n)) if n <= 12 => List("org.scala-lang.modules" %% "scala-collection-compat" % "2.2.0")
+        case _ => Nil
+      }
+    },
+    unmanagedSourceDirectories in Compile ++= {
+      val sourceDir = (sourceDirectory in Compile).value
+      CrossVersion.partialVersion(scalaVersion.value) match {
+        case Some((2, n)) if n <= 11 => Seq(sourceDir / "scala-2.11")
+        case _ => Seq()
+      }
+    },
+    scalacOptions ++= Seq()
   )
+  .jvmPlatform(scalaVersions = Seq(scala213, scala212, scala211))
 
-lazy val examples = project
-  .in(file("examples"))
+lazy val examples = (projectMatrix in file("examples"))
   .settings(commonSettings)
   .settings(
     name := "scala-examples",
@@ -51,15 +129,16 @@ lazy val examples = project
     )
   )
   .dependsOn(cucumberScala % Test)
-
-// TODO cross build
+  .jvmPlatform(scalaVersions = Seq(scala213, scala212))
 
 // TODO code generation for i18n
 
-// TODO scla compiler flags
-
 // TODO OSS publish settings
 // But not the examples
 
 // TODO src jar ?
-// TODO javadoc jar
+// TODO javadoc jar
+
+// TODO Travis
+
+// TODO Makefile

cucumber-scala/src/main/scala-2.11/io/cucumber/scala/package.scala

@@ -0,0 +1,122 @@
+package io.cucumber
+
+import java.lang.reflect.Type
+import java.util.function.Supplier
+import java.util.{List => JavaList, Map => JavaMap}
+
+import io.cucumber.cucumberexpressions.{CaptureGroupTransformer, ParameterByTypeTransformer}
+import io.cucumber.datatable._
+import io.cucumber.docstring.DocStringType.Transformer
+
+/**
+ * Only for Scala 2.11 which does not support some Single Abstract Method
+ */
+package object scala {
+
+  import language.implicitConversions
+
+  // Cucumber Scala Types
+
+  implicit def function1AsDataTableEntryDefinitionBody[T](f: (Map[String, String]) => T): DataTableEntryDefinitionBody[T] = new DataTableEntryDefinitionBody[T] {
+    override def transform(entry: Map[String, String]): T = f.apply(entry)
+  }
+
+  implicit def function1AsDataTableOptionalEntryDefinitionBody[T](f: (Map[String, Option[String]]) => T): DataTableOptionalEntryDefinitionBody[T] = new DataTableOptionalEntryDefinitionBody[T] {
+    override def transform(entry: Map[String, Option[String]]): T = f.apply(entry)
+  }
+
+  implicit def function1AsDataTableRowDefinitionBody[T](f: (Seq[String]) => T): DataTableRowDefinitionBody[T] = new DataTableRowDefinitionBody[T] {
+    override def transform(row: Seq[String]): T = f.apply(row)
+  }
+
+  implicit def function1AsDataTableOptionalRowDefinitionBody[T](f: (Seq[Option[String]]) => T): DataTableOptionalRowDefinitionBody[T] = new DataTableOptionalRowDefinitionBody[T] {
+    override def transform(row: Seq[Option[String]]): T = f.apply(row)
+  }
+
+  implicit def function1AsDataTableCellDefinitionBody[T](f: (String) => T): DataTableCellDefinitionBody[T] = new DataTableCellDefinitionBody[T] {
+    override def transform(cell: String): T = f.apply(cell)
+  }
+
+  implicit def function1AsDataTableOptionalCellDefinitionBody[T](f: (Option[String]) => T): DataTableOptionalCellDefinitionBody[T] = new DataTableOptionalCellDefinitionBody[T] {
+    override def transform(cell: Option[String]): T = f.apply(cell)
+  }
+
+  implicit def function1AsDataTableDefinitionBody[T](f: (DataTable) => T): DataTableDefinitionBody[T] = new DataTableDefinitionBody[T] {
+    override def transform(dataTable: DataTable): T = f.apply(dataTable)
+  }
+
+  // Cucumber Core Types
+
+  implicit def function1AsTableCellTransformer[T](f: String => T): TableCellTransformer[T] = {
+    new TableCellTransformer[T] {
+      override def transform(cell: String): T = f.apply(cell)
+    }
+  }
+
+  implicit def function1AsTableTransformer[T](f: DataTable => T): TableTransformer[T] = {
+    new TableTransformer[T] {
+      override def transform(table: DataTable): T = f.apply(table)
+    }
+  }
+
+  implicit def function1AsTableEntryTransformer[T](f: JavaMap[String, String] => T): TableEntryTransformer[T] = {
+    new TableEntryTransformer[T] {
+      override def transform(entry: JavaMap[String, String]): T = f.apply(entry)
+    }
+  }
+
+  implicit def function1AsTableRowTransformer[T](f: JavaList[String] => T): TableRowTransformer[T] = {
+    new TableRowTransformer[T] {
+      override def transform(row: JavaList[String]): T = f.apply(row)
+    }
+  }
+
+  implicit def function1AsTableCellByTypeTransformer(f: (String, Type) => AnyRef): TableCellByTypeTransformer = {
+    new TableCellByTypeTransformer {
+      override def transform(fromValue: String, toTypeValue: Type): AnyRef = {
+        f.apply(fromValue, toTypeValue)
+      }
+    }
+  }
+
+  implicit def function1AsTableEntryByTypeTransformer(f: (JavaMap[String, String], Type, TableCellByTypeTransformer) => AnyRef): TableEntryByTypeTransformer = {
+    new TableEntryByTypeTransformer {
+      override def transform(fromValue: JavaMap[String, String], toValueType: Type, tableCellByTypeTransformer: TableCellByTypeTransformer): AnyRef = {
+        f.apply(fromValue, toValueType, tableCellByTypeTransformer)
+      }
+    }
+  }
+
+  implicit def function1AsParameterByTypeTransformer(f: (String, Type) => AnyRef): ParameterByTypeTransformer = {
+    new ParameterByTypeTransformer {
+      override def transform(fromValue: String, toValue: Type): AnyRef = {
+        f.apply(fromValue, toValue)
+      }
+    }
+  }
+
+  implicit def function1AsTransformer[T](f: (String) => T): Transformer[T] = {
+    new Transformer[T] {
+      override def transform(s: String): T = {
+        f.apply(s)
+      }
+    }
+  }
+
+  implicit def function1AsCaptureGroupTransformer[T](f: (Array[String]) => T): CaptureGroupTransformer[T] = {
+    new CaptureGroupTransformer[T] {
+      override def transform(parameterContent: Array[String]): T = {
+        f.apply(parameterContent)
+      }
+    }
+  }
+
+  // For tests
+
+  implicit def function1AsSupplier[T](f: () => T): Supplier[T] = {
+    new Supplier[T] {
+      override def get(): T = f.apply()
+    }
+  }
+
+}

examples/src/main/scala/cucumber/examples/scalacalculator/RpnCalculator.scala

@@ -19,15 +19,17 @@ class RpnCalculator {
   private def op(f: (Double, Double) => Double) =
     stack += f(stack.dequeue(), stack.dequeue())
 
-  def push(arg: Arg) {
+  def push(arg: Arg): Unit = {
     arg match {
       case Op("+") => op(_ + _)
       case Op("-") => op(_ - _)
       case Op("*") => op(_ * _)
       case Op("/") => op(_ / _)
       case Val(value) => stack += value
+      case _ => ()
     }
+    ()
   }
 
-  def value = stack.head
+  def value: Double = stack.head
 }

examples/src/test/scala/cucumber/examples/scalacalculator/RpnCalculatorStepDefinitions.scala

@@ -18,6 +18,6 @@ class RpnCalculatorStepDefinitions extends ScalaDsl with EN {
   }
 
   Before("not @foo"){ scenario : Scenario =>
-    println("Runs before scenarios *not* tagged with @foo")
+    println(s"Runs before scenarios *not* tagged with @foo (${scenario.getId})")
   }
 }

project/plugins.sbt

@@ -0,0 +1 @@
+addSbtPlugin("com.eed3si9n" % "sbt-projectmatrix" % "0.6.0")