Skip to content

Set postcss deps as peerDeps? #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joeybaker opened this issue Aug 5, 2015 · 6 comments
Closed

Set postcss deps as peerDeps? #5

joeybaker opened this issue Aug 5, 2015 · 6 comments

Comments

@joeybaker
Copy link
Contributor

It might be cleaner to have all the postcss deps as peerDeps? That way users of this module can set their own versions.

@mightyaleksey
Copy link
Member

Aren't peerDeps deprecated in npm? I heard, they are going to remove it completely in the npm v3.0.0

@joeybaker
Copy link
Contributor Author

well… no. They're not removed, they're changing behavior. In npm 2, peerDeps were auto-installed, and installs broke when this auto-install failed. In npm 3, peerDeps aren't auto-installed. It's up to the user to install the version they want.

@mightyaleksey
Copy link
Member

Well, I lack information about the topic, so I don't to know to what possible problems that solution can lead. Let me think a little about it.

Currently, I want to fix test, so it will be possible to publish it. After that, I'll look on it closely.

@nkbt
Copy link
Contributor

nkbt commented Aug 5, 2015

You should definitely use peerDeps, they work fine and they will for even better.

@mightyaleksey
Copy link
Member

I have to agree with you. Having postcss and its plugins as peerDeps is a good idea. It will be convenient both for the user and for maintainer (less updates).
I read npm documentation and made few tests with [email protected] and presumably it works well.

Documentation:

pr: #12

@mightyaleksey
Copy link
Member

I published update, so you may try to use it :)
Version 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants