We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The return in https://github.com/css-modules/css-modules-require-hook/blob/master/src/index.js#L58 means that the generateScopedName option is ignored when postcss plugins are configured (with use).
generateScopedName
use
It looks like #34 was intended to address this, but as far as I can tell it doesn't. The return statement continues to be a problem.
Replacing
if (customPlugins) { return void (plugins = customPlugins); } plugins = [];
with
if (customPlugins) { plugins = customPlugins; } else { plugins = []; }
(or at least hacking in the equivalent in dist) works for me. I'm not sure if it would break any other use cases.
dist
I have a feeling that I may be simply overlooking or misunderstanding something.
The text was updated successfully, but these errors were encountered:
Hi, can you show your set up or at least describe how you want to use it?
generateScopedName function usually passed to the scope plugin. That's why it will not work if you specify the custom list of plugins with use.
Sorry, something went wrong.
There was nothing in the scope plugin's documentation about how to configure the {{generateScopedName}}, so I didn't go that route.
Now that I've looked at the plugin's source, I see that it is simply an option that can be passed. So I'll do that.
I shouldn't have been quite so lazy in the first place. Sorry for the noise.
It's ok, I guess I'd better update the readme file :)
Thank you for your concern
No branches or pull requests
The return in https://github.com/css-modules/css-modules-require-hook/blob/master/src/index.js#L58 means that the
generateScopedName
option is ignored when postcss plugins are configured (withuse
).It looks like #34 was intended to address this, but as far as I can tell it doesn't. The return statement continues to be a problem.
Replacing
with
(or at least hacking in the equivalent in
dist
) works for me. I'm not sure if it would break any other use cases.I have a feeling that I may be simply overlooking or misunderstanding something.
The text was updated successfully, but these errors were encountered: