Remove some warnings

Author: facchinm

cores/arduino/cm_backtrace/cmb_def.h

@@ -395,18 +395,25 @@ if (!(EXPR))                                                                   \
     }
 #pragma diag_default=Pe940  
 #elif defined(__GNUC__)
+
+#ifdef __cplusplus
+#   define CMSREGISTER
+#else
+#   define CMSREGISTER register
+#endif
+
     __attribute__( ( always_inline ) ) static inline uint32_t cmb_get_msp(void) {
-        register uint32_t result;
+        CMSREGISTER uint32_t result;
         __asm volatile ("MRS %0, msp\n" : "=r" (result) );
         return(result);
     }
     __attribute__( ( always_inline ) ) static inline uint32_t cmb_get_psp(void) {
-        register uint32_t result;
+        CMSREGISTER uint32_t result;
         __asm volatile ("MRS %0, psp\n" : "=r" (result) );
         return(result);
     }
     __attribute__( ( always_inline ) ) static inline uint32_t cmb_get_sp(void) {
-        register uint32_t result;
+        CMSREGISTER uint32_t result;
         __asm volatile ("MOV %0, sp\n" : "=r" (result) );
         return(result);
     }

cores/arduino/main.cpp

@@ -1,5 +1,7 @@
 #include "Arduino.h"
-#include "cm_backtrace/cm_backtrace.h"
+extern "C" {
+   #include "cm_backtrace/cm_backtrace.h"
+}
 
 /* TODO: make me configurable by the variant */
 extern const uint32_t __StackTop;
@@ -120,7 +122,7 @@ void arduino_main(void)
 /* for printf compatibility */
 extern "C" __attribute__((weak)) int _write (int fhdl, const void *buf, size_t count) {
   (void)fhdl;
-  Serial.write_raw((uint8_t*)buf, count);
+  return Serial.write_raw((uint8_t*)buf, count);
 }
 #endif
 

cores/arduino/usb/USB.cpp

@@ -391,34 +391,50 @@ extern "C" __attribute((weak)) void tud_hid_set_report_cb(uint8_t instance, uint
 
 
 extern "C" __attribute((weak))  int32_t tud_msc_read10_cb (uint8_t lun, uint32_t lba, uint32_t offset, void* buffer, uint32_t bufsize) {
-   
+    (void) lun;
+    (void) lba;
+    (void) offset;
+    (void) buffer;
+    (void) bufsize;
     return 0;
 }
 
 
 extern "C" __attribute((weak)) int32_t tud_msc_write10_cb (uint8_t lun, uint32_t lba, uint32_t offset, uint8_t* buffer, uint32_t bufsize) {
-    
+    (void) lun;
+    (void) lba;
+    (void) offset;
+    (void) buffer;
+    (void) bufsize;
     return 0;
 }
 
 
 extern "C"  __attribute((weak)) void tud_msc_inquiry_cb(uint8_t lun, uint8_t vendor_id[8], uint8_t product_id[16], uint8_t product_rev[4]) {
-    
+    (void) lun;
+    (void) vendor_id;
+    (void) product_id;
+    (void) product_rev;
 }
 
 
 extern "C"  __attribute((weak)) bool tud_msc_test_unit_ready_cb(uint8_t lun) {
-    
+    (void) lun;
     return false;
 }
 
 
 extern "C"  __attribute((weak))  void tud_msc_capacity_cb(uint8_t lun, uint32_t* block_count, uint16_t* block_size) {
-   
+    (void) lun;
+    (void) block_count;
+    (void) block_size;
 }
 
 
 extern "C"  __attribute((weak))  int32_t tud_msc_scsi_cb (uint8_t lun, uint8_t const scsi_cmd[16], void* buffer, uint16_t bufsize) {
-    
+    (void) lun;
+    (void) scsi_cmd;
+    (void) buffer;
+    (void) bufsize;
     return -1;
 }

variants/PORTENTA_C33/variant.cpp

@@ -222,7 +222,7 @@ agt_extended_cfg_t TIMER_ETHERNET_extend;
 timer_cfg_t TIMER_ETHERNET_cfg;
 
 
-void startETHClock() {
+fsp_err_t startETHClock() {
   pinPeripheral(ETHERNET_CLK_PIN, (uint32_t) (IOPORT_CFG_PERIPHERAL_PIN | IOPORT_PERIPHERAL_AGT));
 
   TIMER_ETHERNET_extend.count_source = AGT_CLOCK_PCLKB;
@@ -246,10 +246,20 @@ void startETHClock() {
   TIMER_ETHERNET_cfg.cycle_end_irq = FSP_INVALID_VECTOR;
 
   fsp_err_t err = R_AGT_Open(&TIMER_ETHERNET_ctrl,&TIMER_ETHERNET_cfg);
+  if (err != FSP_SUCCESS) {
+    return err;
+  }
   err = R_AGT_Enable(&TIMER_ETHERNET_ctrl);
+  if (err != FSP_SUCCESS) {
+    return err;
+  }
   err = R_AGT_Start(&TIMER_ETHERNET_ctrl);
+  if (err != FSP_SUCCESS) {
+    return err;
+  }
 
   FspTimer::set_timer_is_used(AGT_TIMER, AGT_TIMER_CHANNEL);
+  return err;
 }
 
 void initVariant() {