Skip to content

Commit 4125cec

Browse files
committed
PoC of using latest code with graphql-java v20 and Java 8
Unfortunately, we still have a need for this. graphql-java-kickstart#411
1 parent 05d7f03 commit 4125cec

File tree

3 files changed

+16
-29
lines changed

3 files changed

+16
-29
lines changed

pom.xml

+13-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>com.graphql-java-kickstart</groupId>
66
<artifactId>graphql-java-tools</artifactId>
7-
<version>13.1.2-SNAPSHOT</version>
7+
<version>13.1.2-SAMS-SNAPSHOT</version>
88
<packaging>jar</packaging>
99

1010
<name>GraphQL Java Tools</name>
@@ -13,11 +13,11 @@
1313

1414
<properties>
1515
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
16-
<java.version>11</java.version>
16+
<java.version>1.8</java.version>
1717
<kotlin.version>1.8.21</kotlin.version>
1818
<kotlin-coroutines.version>1.7.3</kotlin-coroutines.version>
1919
<jackson.version>2.15.3</jackson.version>
20-
<graphql-java.version>21.3</graphql-java.version>
20+
<graphql-java.version>20.7</graphql-java.version>
2121
<reactive-streams.version>1.0.4</reactive-streams.version>
2222

2323
<maven.compiler.source>${java.version}</maven.compiler.source>
@@ -146,6 +146,14 @@
146146
<groupId>org.jetbrains.kotlin</groupId>
147147
<artifactId>kotlin-reflect</artifactId>
148148
</dependency>
149+
<dependency>
150+
<!--
151+
TODO not sure what's right to use for kotlin coroutines on Java 8.
152+
-->
153+
<groupId>org.jetbrains.kotlinx</groupId>
154+
<artifactId>kotlinx-coroutines-jdk8</artifactId>
155+
</dependency>
156+
149157
<dependency>
150158
<!--
151159
Depending on kotlinx-coroutines-core causes an ambiguous module reference warning.
@@ -286,8 +294,8 @@
286294
<artifactId>maven-compiler-plugin</artifactId>
287295
<version>3.11.0</version>
288296
<configuration>
289-
<source>11</source>
290-
<target>11</target>
297+
<source>8</source>
298+
<target>8</target>
291299
</configuration>
292300
</plugin>
293301

src/main/kotlin/module-info.java

-24
This file was deleted.

src/test/kotlin/graphql/kickstart/tools/InaccessibleFieldResolverTest.kt

+3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ import java.util.*
1414
*/
1515
class InaccessibleFieldResolverTest {
1616

17+
/*
18+
TODO are any of these valid for Java 8? Should have seen if these existed in v13.0.x work.
1719
@Test
1820
fun `private field from closed module is not accessible`() {
1921
val schema: GraphQLSchema = SchemaParser.newParser()
@@ -50,6 +52,7 @@ class InaccessibleFieldResolverTest {
5052
val exceptionWhileDataFetching = result.errors[0] as ExceptionWhileDataFetching
5153
assert(exceptionWhileDataFetching.exception is IllegalAccessException)
5254
}
55+
*/
5356

5457
@Test
5558
fun `private field from closed module is accessible through resolver`() {

0 commit comments

Comments
 (0)