From fdba23d7bb8c5dadbfd1c14c138abc773fd8e1d5 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 6 May 2024 15:18:38 -0700 Subject: [PATCH 1/5] test glob-ignores branch as py pkg --- .github/workflows/cpp-lint-package.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 99d1c81..3481368 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -7,6 +7,7 @@ on: description: 'which branch to test' default: 'main' required: true + push: jobs: cpp-linter: @@ -16,7 +17,7 @@ jobs: matrix: clang-version: ['7', '8', '9','10', '11', '12', '13', '14', '15', '16', '17'] repo: ['cpp-linter/cpp-linter'] - branch: ['${{ inputs.branch }}'] + branch: ['glob-ignores'] # ['${{ inputs.branch }}'] fail-fast: false steps: From 9de50bddc09c443fd0bdf20059b841bb309eedd7 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 6 May 2024 15:22:06 -0700 Subject: [PATCH 2/5] test PR events --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 3481368..f9555ca 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -7,7 +7,7 @@ on: description: 'which branch to test' default: 'main' required: true - push: + pull_request: jobs: cpp-linter: From a9a3e855d9f9ed2e62f9ccd14fb5ac7ef9d02837 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 13 May 2024 17:09:49 -0700 Subject: [PATCH 3/5] exclude hpp files from tidy analysis --- .github/workflows/cpp-lint-package.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index f9555ca..5bdd2a4 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -67,6 +67,7 @@ jobs: --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} + --ignore-tidy='*.hpp' - name: Fail fast?! if: steps.linter.outputs.checks-failed > 0 From 4cb37bf84e7a639f39d80e84fa4b30b4332e54e6 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 13 May 2024 17:13:50 -0700 Subject: [PATCH 4/5] switch to main branch of cpp-linter pkg --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 5bdd2a4..8279114 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -17,7 +17,7 @@ jobs: matrix: clang-version: ['7', '8', '9','10', '11', '12', '13', '14', '15', '16', '17'] repo: ['cpp-linter/cpp-linter'] - branch: ['glob-ignores'] # ['${{ inputs.branch }}'] + branch: ['main'] # ['${{ inputs.branch }}'] fail-fast: false steps: From eab0fcc969e5739f800a3df998f59450a5bbff72 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 13 May 2024 17:18:46 -0700 Subject: [PATCH 5/5] exclude hpp files from format analysis --- .github/workflows/cpp-lint-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 8279114..36cf1b1 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -65,9 +65,9 @@ jobs: -V=${{ runner.temp }}/llvm -f=false --extra-arg="-std=c++14 -Wall" - --thread-comments=${{ matrix.clang-version == '12' }} + --thread-comments=${{ matrix.clang-version == '12' && 'update' }} -a=${{ matrix.clang-version == '12' }} - --ignore-tidy='*.hpp' + --ignore-format='*.hpp' - name: Fail fast?! if: steps.linter.outputs.checks-failed > 0