add tests

Author: 2bndy5

cpp-linter-lib/src/cli/mod.rs

@@ -295,13 +295,13 @@ Further filtering can still be applied (see [Source options](#source-options))."
             )
             .groups([
                 ArgGroup::new("Clang-tidy options")
-                    .args(["tidy-checks", "database", "extra-arg", "ignore-tidy"]),
-                ArgGroup::new("Clang-format options").args(["style", "ignore-format"]),
-                ArgGroup::new("General options").args(["verbosity", "version"]),
-                ArgGroup::new("Source options").args(["extensions", "repo-root", "ignore", "lines-changed-only", "files-changed-only"]),
+                    .args(["tidy-checks", "database", "extra-arg", "ignore-tidy"]).multiple(true),
+                ArgGroup::new("Clang-format options").args(["style", "ignore-format"]).multiple(true),
+                ArgGroup::new("General options").args(["verbosity", "version"]).multiple(true),
+                ArgGroup::new("Source options").args(["extensions", "repo-root", "ignore", "lines-changed-only", "files-changed-only"]).multiple(true),
                 ArgGroup::new("Feedback options").args([
                     "thread-comments", "no-lgtm", "step-summary", "file-annotations"
-                ]),
+                ]).multiple(true),
             ])
             .next_line_help(true)
 }

cpp-linter-lib/src/cli/structs.rs

@@ -45,6 +45,7 @@ pub struct Cli {
     pub no_lgtm: bool,
     pub step_summary: bool,
     pub file_annotations: bool,
+    pub not_ignored: Option<Vec<String>>,
 }
 
 impl From<&ArgMatches> for Cli {
@@ -101,6 +102,9 @@ impl From<&ArgMatches> for Cli {
             step_summary: args.get_flag("step-summary"),
             thread_comments,
             file_annotations: args.get_flag("file-annotations"),
+            not_ignored: args
+                .get_many::<String>("files")
+                .map(|files| Vec::from_iter(files.map(|v| v.to_owned()))),
         }
     }
 }
@@ -196,3 +200,21 @@ impl Default for FeedbackInput {
         }
     }
 }
+
+#[cfg(test)]
+mod test {
+    use crate::cli::get_arg_parser;
+
+    use super::Cli;
+
+    #[test]
+    fn parse_positional() {
+        let parser = get_arg_parser();
+        let args = parser.get_matches_from(["cpp-linter", "file1.c", "file2.h"]);
+        let cli = Cli::from(&args);
+        let not_ignored = cli.not_ignored.expect("failed to parse positional args");
+        assert!(!not_ignored.is_empty());
+        assert!(not_ignored.contains(&String::from("file1.c")));
+        assert!(not_ignored.contains(&String::from("file2.h")));
+    }
+}

cpp-linter-lib/src/run.rs

@@ -65,7 +65,8 @@ pub async fn run_main(args: Vec<String>) -> i32 {
     }
 
     if cli.repo_root != "." {
-        env::set_current_dir(Path::new(&cli.repo_root)).unwrap();
+        env::set_current_dir(Path::new(&cli.repo_root))
+            .unwrap_or_else(|_| panic!("'{}' is inaccessible or does not exist", cli.repo_root));
     }
 
     let rest_api_client = GithubApiClient::new();
@@ -78,6 +79,9 @@ pub async fn run_main(args: Vec<String>) -> i32 {
 
     let mut file_filter = FileFilter::new(&cli.ignore, cli.extensions.clone());
     file_filter.parse_submodules();
+    if let Some(files) = &cli.not_ignored {
+        file_filter.not_ignored.extend(files.clone());
+    }
 
     if !file_filter.ignored.is_empty() {
         log::info!("Ignored:");
@@ -92,14 +96,6 @@ pub async fn run_main(args: Vec<String>) -> i32 {
         }
     }
 
-    if let Some(files) = args.get_many::<Vec<String>>("files") {
-        for list in files {
-            file_filter
-                .not_ignored
-                .extend(list.iter().map(|v| v.to_string()).collect::<Vec<String>>());
-        }
-    }
-
     start_log_group(String::from("Get list of specified source files"));
     let files = if cli.lines_changed_only != LinesChangedOnly::Off || cli.files_changed_only {
         // parse_diff(github_rest_api_payload)
@@ -140,7 +136,10 @@ mod test {
             run_main(vec![
                 "cpp-linter".to_string(),
                 "-l".to_string(),
-                "false".to_string()
+                "false".to_string(),
+                "--repo-root".to_string(),
+                "tests".to_string(),
+                "demo/demo.cpp".to_string(),
             ])
             .await,
             0