Skip to content

Commit 8d5d2ff

Browse files
committed
quote bash parameters
move comment note to top of file
1 parent 5d66632 commit 8d5d2ff

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

.github/workflows/binary-builds.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ jobs:
160160
GH_TOKEN: ${{ github.token }}
161161
run: |
162162
files=$(ls dist/cpp-linter*)
163-
gh release upload ${{ github.ref_name }} $files
163+
gh release upload "${{ github.ref_name }}" $files
164164
- run: cargo publish -p cpp-linter
165165
env:
166166
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}

.github/workflows/bump-n-release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: Bump-n-Release
22

3+
# NOTE: The change log is only updated in the remote upon release (in `bump-release` job)
4+
35
on:
46
push:
57
branches:
@@ -58,5 +60,4 @@ jobs:
5860
OUTPUT: ${{ runner.temp }}/changes.md
5961
GITHUB_REPO: ${{ github.repository }}
6062
GITHUB_TOKEN: ${{ secrets.BUMP_N_RELEASE }}
61-
- run: cat ${{ runner.temp }}/changes.md >> $GITHUB_STEP_SUMMARY
62-
# NOTE: The change log is updated upon release in `bump-release` job above
63+
- run: cat "${{ runner.temp }}/changes.md" >> "$GITHUB_STEP_SUMMARY"

.github/workflows/node-js-packaging.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,4 +234,4 @@ jobs:
234234
# GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
235235
# run:
236236
# files=$(ls ./npm/**cpp-linter.*.node)
237-
# gh release upload ${{ github.ref_name }} $files
237+
# gh release upload "${{ github.ref_name }}" $files

.github/workflows/python-packaging.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,4 +192,4 @@ jobs:
192192
# GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
193193
# run:
194194
# files=$(ls ./dist/cpp-linter*.{whl,atr.gz})
195-
# gh release upload ${{ github.ref_name }} $files
195+
# gh release upload "${{ github.ref_name }}" $files

0 commit comments

Comments
 (0)