Fix the cluster settings page in angular ui

The internalSettings/visual REST API was removed recently and that
API was used by the cluster settings page. This change removes the
old API and uses the recommended pools/default API to update the
cluster settings.

Change-Id: I519a03d12cd6b868505e891d49482c0107a9bb18
Reviewed-on: http://review.couchbase.org/49268
Reviewed-by: Pavel Blagodov <[email protected]>
Tested-by: Pavel Blagodov <[email protected]>

Author: mikewied

priv/public/angular/app/mn_admin/mn_admin_config.js

@@ -103,9 +103,6 @@ angular.module('mnAdmin').config(function ($stateProvider, $urlRouterProvider) {
         defaultCertificate: function (mnSettingsClusterService) {
           return mnSettingsClusterService.getDefaultCertificate();
         },
-        getVisulaSettings: function (mnSettingsClusterService) {
-          return mnSettingsClusterService.getVisulaSettings();
-        },
         nodes: function (mnServersService) {
           return mnServersService.getNodes();
         },

priv/public/angular/app/mn_admin/mn_settings/cluster/mn_settings_cluster.html

@@ -5,7 +5,7 @@ <h2>
     </h2>
     <div class="sub_section">
       <label>Cluster Name:</label>
-      <input type="text" name="tabName" maxlength="256" ng-model="formData.tabName">
+      <input type="text" name="clusterName" maxlength="256" ng-model="formData.clusterName">
       <span>(0 — 256 chars)</span>
     </div>
     <div class="certificate_section">

priv/public/angular/app/mn_admin/mn_settings/cluster/mn_settings_cluster_controller.js

@@ -1,34 +1,34 @@
 angular.module('mnSettingsCluster').controller('mnSettingsClusterController',
-  function ($scope, mnSettingsClusterService, nodes, poolDefault, defaultCertificate, getVisulaSettings, mnHelper) {
+  function ($scope, mnSettingsClusterService, nodes, poolDefault, defaultCertificate, mnHelper) {
     $scope.focusMe = true;
 
     $scope.formData = {};
-    $scope.formData.tabName = getVisulaSettings.data.tabName;
+    $scope.formData.clusterName = poolDefault.clusterName;
     $scope.formData.memoryQuota = getInMegs(poolDefault.storageTotals.ram.quotaTotalPerNode);
     $scope.totalRam = getInMegs(nodes.ramTotalPerActiveNode);
     $scope.maxRamMegs = Math.max(getInMegs(nodes.ramTotalPerActiveNode) - 1024, Math.floor(nodes.ramTotalPerActiveNode * 4 / (5 * Math.Mi)));
     setCertificate(defaultCertificate.data);
 
     var liveValidation = _.debounce(function () {
-      mnSettingsClusterService.visualInternalSettingsValidation($scope.formData).error(setError).success(setError);
+      var promise = mnSettingsClusterService.clusterSettingsValidation($scope.formData);
+      mnHelper.promiseHelper($scope, promise).catchErrorsFromSuccess();
     }, 500);
 
     $scope.$watch('formData.memoryQuota', liveValidation);
 
     function setCertificate(certificate) {
       $scope.certificate = certificate;
     }
-    function setError(response) {
-      $scope.errors = response.errors;
-    }
+
     function getInMegs(value) {
       return Math.floor(value / Math.Mi);
     }
 
     $scope.saveVisualInternalSettings = function () {
-      var promise = mnSettingsClusterService.saveVisualInternalSettings($scope.formData).error(setError);
+      var promise = mnSettingsClusterService.saveClusterSettings($scope.formData);
       mnHelper
         .promiseHelper($scope, promise)
+        .catchErrorsFromSuccess()
         .showSpinner('settingsClusterLoaded')
         .reloadState();
     };

priv/public/angular/app/mn_admin/mn_settings/cluster/mn_settings_cluster_service.js

@@ -15,27 +15,21 @@ angular.module('mnSettingsClusterService').factory('mnSettingsClusterService',
         url: '/controller/regenerateCertificate'
       });
     };
-    mnSettingsClusterService.getVisulaSettings = function () {
-      return mnHttp({
-        method: 'GET',
-        url: '/internalSettings/visual'
-      });
-    };
-    mnSettingsClusterService.saveVisualInternalSettings = function (data) {
+    mnSettingsClusterService.saveClusterSettings = function (data) {
       return mnHttp({
         method: 'POST',
-        url: '/internalSettings/visual',
+        url: '/pools/default',
         data: data
       });
     };
-    mnSettingsClusterService.visualInternalSettingsValidation = function (data) {
+    mnSettingsClusterService.clusterSettingsValidation = function (data) {
       return mnHttp({
         method: 'POST',
         params: {
           just_validate: 1,
         },
         data: data,
-        url: '/internalSettings/visual'
+        url: '/pools/default'
       });
     };