Skip to content

Commit e4ebfb7

Browse files
authored
Upate update build image instruction with things to note about GOPROXY (#4823)
Signed-off-by: Alvin Lin <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
1 parent e3b21d3 commit e4ebfb7

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Diff for: docs/contributing/how-to-update-the-build-image.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ slug: how-to-update-the-build-image
88
The build image currently can only be updated by a Cortex maintainer. If you're not a maintainer you can still open a PR with the changes, asking a maintainer to assist you publishing the updated image. The procedure is:
99

1010
1. Update `build-image/Docker`.
11-
2. Build the and publish the image by using `make push-multiarch-build-image`. This will build and push multiplatform docker image (for linux/amd64 and linux/arm64). Pushing to `quay.io/cortexproject/build-image` repository can only be done by a maintainer. Running this step successfully requires [Docker Buildx](https://docs.docker.com/buildx/working-with-buildx/), but does not require a specific platform.
12-
3. Replace the image tag in `.github/workflows/*` (_there may be multiple references_) and Makefile (variable `LATEST_BUILD_IMAGE_TAG`).
13-
4. Open a PR and make sure the CI with new build-image passes
11+
1. Run `go env` and make sure `GOPROXY=https://proxy.golang.org,direct` (Go's default). Some environment may required `GOPROXY=direct`, and if you push a build image with this, build workflow on GitHub will take a lot longer to download modules.
12+
1. Build the and publish the image by using `make push-multiarch-build-image`. This will build and push multiplatform docker image (for linux/amd64 and linux/arm64). Pushing to `quay.io/cortexproject/build-image` repository can only be done by a maintainer. Running this step successfully requires [Docker Buildx](https://docs.docker.com/buildx/working-with-buildx/), but does not require a specific platform.
13+
1. Replace the image tag in `.github/workflows/*` (_there may be multiple references_) and Makefile (variable `LATEST_BUILD_IMAGE_TAG`).
14+
1. Open a PR and make sure the CI with new build-image passes
15+
16+

0 commit comments

Comments
 (0)