Skip to content

Commit caaddfb

Browse files
authored
Emit more histogram buckets for cortex-querier_storegateway_refetches_per_query (#6570)
Signed-off-by: SungJin1212 <[email protected]>
1 parent 9e4fd0d commit caaddfb

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

Diff for: CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## master / unreleased
44

55
* [FEATURE] Querier/Ruler: Add `query_partial_data` and `rules_partial_data` limits to allow queries/rules to be evaluated with data from a single zone, if other zones are not available. #6526
6+
* [ENHANCEMENT] StoreGateway: Emit more histogram buckets on the `cortex_querier_storegateway_refetches_per_query` metric. #6570
67
* [ENHANCEMENT] Querier: Apply bytes limiter to LabelNames and LabelValuesForLabelNames. #6568
78
* [ENHANCEMENT] Query Frontend: Add a `too_many_tenants` reason label value to `cortex_rejected_queries_total` metric to track the rejected query count due to the # of tenant limits. #6569
89
* [BUGFIX] Ingester: Avoid error or early throttling when READONLY ingesters are present in the ring #6517

Diff for: pkg/querier/blocks_store_queryable.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ func newBlocksStoreQueryableMetrics(reg prometheus.Registerer) *blocksStoreQuery
123123
Namespace: "cortex",
124124
Name: "querier_storegateway_refetches_per_query",
125125
Help: "Number of re-fetches attempted while querying store-gateway instances due to missing blocks.",
126-
Buckets: []float64{0, 1, 2},
126+
Buckets: []float64{0, 1, 2, 4, 8},
127127
}),
128128
}
129129
}

Diff for: pkg/querier/blocks_store_queryable_test.go

+8
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,8 @@ func TestBlocksStoreQuerier_Select(t *testing.T) {
614614
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 1
615615
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 1
616616
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
617+
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
618+
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
617619
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
618620
cortex_querier_storegateway_refetches_per_query_sum 0
619621
cortex_querier_storegateway_refetches_per_query_count 1
@@ -913,6 +915,8 @@ func TestBlocksStoreQuerier_Select(t *testing.T) {
913915
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 0
914916
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 0
915917
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
918+
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
919+
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
916920
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
917921
cortex_querier_storegateway_refetches_per_query_sum 2
918922
cortex_querier_storegateway_refetches_per_query_count 1
@@ -1850,6 +1854,8 @@ func TestBlocksStoreQuerier_Labels(t *testing.T) {
18501854
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 1
18511855
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 1
18521856
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
1857+
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
1858+
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
18531859
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
18541860
cortex_querier_storegateway_refetches_per_query_sum 0
18551861
cortex_querier_storegateway_refetches_per_query_count 1
@@ -2078,6 +2084,8 @@ func TestBlocksStoreQuerier_Labels(t *testing.T) {
20782084
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 0
20792085
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 0
20802086
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
2087+
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
2088+
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
20812089
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
20822090
cortex_querier_storegateway_refetches_per_query_sum 2
20832091
cortex_querier_storegateway_refetches_per_query_count 1

0 commit comments

Comments
 (0)