Dropping support Prometheus 1.x rule format on configdb (#4826)

* Dropping support Prometheus 1.x rule format on configdb

Signed-off-by: Alan Protasio <[email protected]>

* Update Changelog

Signed-off-by: Alan Protasio <[email protected]>

Signed-off-by: Alan Protasio <[email protected]>

Author: alanprot

Diff for: CHANGELOG.md

@@ -39,6 +39,7 @@
   - `-flusher.wal-dir`, `-flusher.concurrent-flushes`, `-flusher.flush-op-timeout`
 * [CHANGE] Remove support for alertmanager and ruler legacy store configuration. Before upgrading, you need to convert your configuration to use the `alertmanager-storage` and `ruler-storage` configuration on the version that you're already running, then upgrade.
 * [CHANGE] Disables TSDB isolation. #4825
+* [CHANGE] Drops support Prometheus 1.x rule format on configdb. #4826
 * [ENHANCEMENT] Querier/Ruler: Retry store-gateway in case of unexpected failure, instead of failing the query. #4532
 * [ENHANCEMENT] Ring: DoBatch prioritize 4xx errors when failing. #4783
 * [ENHANCEMENT] Cortex now built with Go 1.18. #4829

Diff for: pkg/configs/api/api_test.go

@@ -293,7 +293,7 @@ func Test_SetConfig_ValidatesAlertmanagerConfig(t *testing.T) {
 
 	userID := makeUserID()
 	for i, test := range amCfgValidationTests {
-		cfg := userconfig.Config{AlertmanagerConfig: test.config}
+		cfg := userconfig.Config{AlertmanagerConfig: test.config, RulesConfig: userconfig.RulesConfig{FormatVersion: userconfig.RuleFormatV2}}
 		resp := requestAsUser(t, userID, "POST", "/api/prom/configs/alertmanager", "", readerFromConfig(t, cfg))
 
 		if !test.shouldFail {
@@ -322,7 +322,7 @@ func Test_SetConfig_ValidatesAlertmanagerConfig_WithEmailEnabled(t *testing.T) {
 	defer cleanup(t)
 
 	userID := makeUserID()
-	cfg := userconfig.Config{AlertmanagerConfig: config}
+	cfg := userconfig.Config{AlertmanagerConfig: config, RulesConfig: userconfig.RulesConfig{FormatVersion: userconfig.RuleFormatV2}}
 	resp := requestAsUser(t, userID, "POST", "/api/prom/configs/alertmanager", "", readerFromConfig(t, cfg))
 
 	assert.Equal(t, http.StatusNoContent, resp.Code)

Diff for: pkg/configs/api/helpers_test.go

@@ -96,7 +96,7 @@ func makeConfig() userconfig.Config {
 
             receivers:
             - name: noop`),
-		RulesConfig: userconfig.RulesConfig{},
+		RulesConfig: userconfig.RulesConfig{FormatVersion: userconfig.RuleFormatV2},
 	}
 }