Skip to content

CI Node version matrix not applied #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annaerdi opened this issue Apr 6, 2025 · 0 comments
Open

CI Node version matrix not applied #319

annaerdi opened this issue Apr 6, 2025 · 0 comments

Comments

@annaerdi
Copy link

annaerdi commented Apr 6, 2025

CI Node version matrix not applied – using default Node 20.x (Ubuntu) and 18.x (Windows) for all 6 runs.

  • Operating system and version: GitHub-hosted runners (ubuntu-latest, windows-latest)
  • Browser and version: N/A (CI-related)

Bug description:

The GitHub Actions workflow .github/workflows/npm.yml defines a matrix to test across Node versions 16.x, 17.x, and 18.x, but the setup-node step references env.node-version, which is not connected to the matrix.

As a result, the matrix is not being used, and the jobs are falling back to the default Node versions provided by GitHub runners.

For example:
build (ubuntu-latest, 17.x) — succeeded but actually ran:

node: v20.19.0
npm: 10.8.2

Suggested fix:

In the workflow file, replace node-version: ${{ env.node-version }} with node-version: ${{ matrix.node-version }}, however, this will likely cause the workflow to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant