Skip to content

Commit 3a315ad

Browse files
committed
fix(BrandButtons): icon spacing tempfix
1 parent bff8968 commit 3a315ad

File tree

3 files changed

+75
-59
lines changed

3 files changed

+75
-59
lines changed

src/views/buttons/BrandButtons.vue

+19-3
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
size="sm"
3131
:key="key"
3232
:color="brandName"
33+
class="btn-brand"
3334
>
3435
<CIcon size="sm" :name="'cib-' + brandName"/>
3536
<span>{{brandName}}</span>
@@ -43,6 +44,7 @@
4344
:name="brandName"
4445
:key="key"
4546
:color="brandName"
47+
class="btn-brand"
4648
>
4749
<CIcon :name="'cib-' + brandName"/>
4850
<span>{{brandName}}</span>
@@ -57,6 +59,7 @@
5759
size="lg"
5860
:key="key"
5961
:color="brandName"
62+
class="btn-brand"
6063
>
6164
<CIcon size="lg" :name="'cib-' + brandName"/>
6265
<span>{{brandName}}</span>
@@ -172,9 +175,9 @@
172175
<script>
173176
export default {
174177
name: 'BrandButtons',
175-
usage: '<CButton color="facebook"><span>Facebook</span></CButton>',
178+
usage: '<CButton color="facebook"><CIcon name="cib-facebook"/><span>Facebook</span></CButton>',
176179
iconsOnlyUsage: '<CButton color="facebook"><CIcon name="cib-facebook"/></CButton>',
177-
textOnlyUsage: '<CButton color="facebook"><CIcon name="cib-facebook"/></CButton>',
180+
textOnlyUsage: '<CButton color="facebook"><span>Facebook</span></CButton>',
178181
brands: [
179182
'facebook',
180183
'twitter',
@@ -216,9 +219,22 @@ export default {
216219
}
217220
</script>
218221

219-
<style scoped>
222+
<style scoped lang="scss">
220223
.btn {
221224
margin-bottom: 4px;
222225
margin-right: 6px;
223226
}
227+
// todo
228+
.btn-brand:not(:only-child) {
229+
.c-icon {
230+
margin-top: 0 !important;
231+
margin-right: 8px;
232+
}
233+
.c-icon-sm {
234+
margin-right: 5px;
235+
}
236+
.c-icon-lg {
237+
margin-right: 12px;
238+
}
239+
}
224240
</style>

tests/unit/views/base/Tooltips.spec.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ describe('Tooltips.vue', () => {
2020
const wrapper = shallowMount(Tooltips)
2121
expect(wrapper.findComponent(Tooltips)).toBeTruthy()
2222
})
23-
test('renders correctly', () => {
24-
const wrapper = shallowMount(Tooltips)
23+
// test('renders correctly', () => {
24+
// const wrapper = shallowMount(Tooltips)
2525
// expect(wrapper.element).toMatchSnapshot()
26-
})
26+
// })
2727
})

0 commit comments

Comments
 (0)