Skip to content

Commit c324997

Browse files
committed
refactor(Dashboard): tweak lazy and Suspense for Widget03
1 parent 05d0d7f commit c324997

File tree

1 file changed

+9
-20
lines changed

1 file changed

+9
-20
lines changed

src/views/Dashboard/Dashboard.js

+9-20
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ import {
2323
import { CustomTooltips } from '@coreui/coreui-plugin-chartjs-custom-tooltips';
2424
import { getStyle, hexToRgba } from '@coreui/coreui/dist/js/coreui-utilities'
2525

26-
// import Widget03 from '../../views/Widgets/Widget03'
2726
const Widget03 = lazy(() => import('../../views/Widgets/Widget03'));
28-
const Loading = () => <div>Loading...</div>
2927

3028
const brandPrimary = getStyle('--primary')
3129
const brandSuccess = getStyle('--success')
@@ -479,6 +477,8 @@ class Dashboard extends Component {
479477
});
480478
}
481479

480+
loading = () => <div className="animated fadeIn pt-1 text-center">Loading...</div>
481+
482482
render() {
483483

484484
return (
@@ -640,7 +640,7 @@ class Dashboard extends Component {
640640

641641
<Row>
642642
<Col xs="6" sm="6" lg="3">
643-
<Suspense fallback={Loading()}>
643+
<Suspense fallback={this.loading()}>
644644
<Widget03 dataBox={() => ({ variant: 'facebook', friends: '89k', feeds: '459' })} >
645645
<div className="chart-wrapper">
646646
<Line data={makeSocialBoxData(0)} options={socialChartOpts} height={90} />
@@ -650,7 +650,7 @@ class Dashboard extends Component {
650650
</Col>
651651

652652
<Col xs="6" sm="6" lg="3">
653-
<Suspense fallback={Loading()}>
653+
<Suspense fallback={this.loading()}>
654654
<Widget03 dataBox={() => ({ variant: 'twitter', followers: '973k', tweets: '1.792' })} >
655655
<div className="chart-wrapper">
656656
<Line data={makeSocialBoxData(1)} options={socialChartOpts} height={90} />
@@ -660,7 +660,7 @@ class Dashboard extends Component {
660660
</Col>
661661

662662
<Col xs="6" sm="6" lg="3">
663-
<Suspense fallback={Loading()}>
663+
<Suspense fallback={this.loading()}>
664664
<Widget03 dataBox={() => ({ variant: 'linkedin', contacts: '500+', feeds: '292' })} >
665665
<div className="chart-wrapper">
666666
<Line data={makeSocialBoxData(2)} options={socialChartOpts} height={90} />
@@ -670,24 +670,13 @@ class Dashboard extends Component {
670670
</Col>
671671

672672
<Col xs="6" sm="6" lg="3">
673-
<div className="brand-card">
674-
<div className="brand-card-header bg-google-plus">
675-
<i className="fa fa-google-plus"></i>
673+
<Suspense fallback={this.loading()}>
674+
<Widget03 dataBox={() => ({ variant: 'google-plus', followers: '894', circles: '92' })} >
676675
<div className="chart-wrapper">
677676
<Line data={makeSocialBoxData(3)} options={socialChartOpts} height={90} />
678677
</div>
679-
</div>
680-
<div className="brand-card-body">
681-
<div>
682-
<div className="text-value">894</div>
683-
<div className="text-uppercase text-muted small">followers</div>
684-
</div>
685-
<div>
686-
<div className="text-value">92</div>
687-
<div className="text-uppercase text-muted small">circles</div>
688-
</div>
689-
</div>
690-
</div>
678+
</Widget03>
679+
</Suspense>
691680
</Col>
692681
</Row>
693682

0 commit comments

Comments
 (0)